This patch will convert yet more administration templates to use the Bootstrap grid: - currency.tt - didyoumean.tt - edi_accounts.tt - edi_ean_accounts.tt - items_search_field.tt - items_search_fields.tt
Created attachment 77017 [details] [review] Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4 This patch modifies several administration templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Administration -> Currencies and exchange rates - View and edit currencies - Administration -> Did you mean? - Administration -> EDI accounts - View and edit accounts - Administration -> Library EANs - View and edit EANs - Administration -> Item search fields - View and edit item search fields
In currencies and exchange rates the table appears to the right of the Column visibility etc buttons. Should it be below rather than next to? Other pages are all fine.
(In reply to Claire Gravely from comment #2) > In currencies and exchange rates the table appears to the right of the > Column visibility etc buttons. Should it be below rather than next to? I have fixed this in a separate bug as it is unrelated to the changes in this patch. Bug 21234.
Created attachment 77927 [details] [review] Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4 This patch modifies several administration templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Administration -> Currencies and exchange rates - View and edit currencies - Administration -> Did you mean? - Administration -> EDI accounts - View and edit accounts - Administration -> Library EANs - View and edit EANs - Administration -> Item search fields - View and edit item search fields Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 77941 [details] [review] Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4 This patch modifies several administration templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Administration -> Currencies and exchange rates - View and edit currencies - Administration -> Did you mean? - Administration -> EDI accounts - View and edit accounts - Administration -> Library EANs - View and edit EANs - Administration -> Item search fields - View and edit item search fields Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I have rebased the patch on top of bug 13618 as it should be the next one to be pushed. Also found bug 21239 while testing (not caused by this patch).
Awesome work all! Pushed to master for 18.11
Enhancement, will not be backported to 18.05.x series.