Bug 20863 - Delete bib_list and intranet_bib_list cookies when cart is emptied out
Summary: Delete bib_list and intranet_bib_list cookies when cart is emptied out
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 18081
  Show dependency treegraph
 
Reported: 2018-06-03 09:09 UTC by Katrin Fischer
Modified: 2020-01-03 15:26 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2018-06-03 09:09:54 UTC
When adding items to the cart, the bib_list or intranet_bib_list cookie is set. When 'emtpy and close' is used the value of the cookie is set to /, but we should just remove it instead.
Comment 1 Owen Leonard 2018-06-04 14:54:05 UTC
I don't find this to be true. The delCookie function in basket.js sets the value of the bib_list cookie to null, sets the path to /, and the expiration to "now minus one" to make it expired.

In my test (Firefox, Windows 10), the cookie is gone after I empty the cart in both the OPAC and staff client.
Comment 2 Katrin Fischer 2018-06-04 15:31:55 UTC
Thx Owen, I'll retest. I was using the firefox build in tools to keep an eye on cookies being added and updated.
Comment 3 Katrin Fischer 2018-06-04 19:49:08 UTC
My cookies seem to be somehow messed up, will try again later.
Comment 4 Katrin Fischer 2018-06-19 21:23:20 UTC
Retested: In staff it worked nicely (apart from bug 20967 found), but in the OPAC  the bib_selected cookie remained with a value of %5B%5D after emptying the cart.