Bug 20931 - JS error "ReferenceError: $ is not defined" when CircSidebar is turned on
Summary: JS error "ReferenceError: $ is not defined" when CircSidebar is turned on
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 16530 19700
Blocks:
  Show dependency treegraph
 
Reported: 2018-06-13 13:01 UTC by Jonathan Druart
Modified: 2018-06-19 12:28 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-06-13 13:01:27 UTC
If CircSidebar is set and you hit /cgi-bin/koha/circ/returns.pl, you will get "ReferenceError: $ is not defined"
Comment 1 Katrin Fischer 2018-06-18 21:42:58 UTC
I can confirm the error, but haven't been able to locate the mistake in the code yet. Only thing I notice is some errors from the validator - 2 stay </div> tags.
Comment 2 Katrin Fischer 2018-06-18 21:44:13 UTC
Ah, I think the JavaScript for navbar needs to be moved to the bottom.
Comment 3 Owen Leonard 2018-06-19 12:28:51 UTC
(In reply to Katrin Fischer from comment #2)
> Ah, I think the JavaScript for navbar needs to be moved to the bottom.

It needs to be moved to a separate JS file or a JS file which is already included on the affected pages. It's on my to-do list but someone else can take it if they want.

As far as I know it's only a cosmetic issue -- the highlighting of the current page won't work.