A proposed enhancement during QA of bug 20312 was to expand it's functionality to become a short last of the last X patrons rather than just the last 1 patron.
Created attachment 152902 [details] [review] Bug 21246: Extend the 'Last patron' navigation feature to 'Last 10 patrons' This retains the "last patron" link, but extends it to add a dropdown containg the last 10 patrons. A future enhancement to control how many patrons to retain would complement this well. 1) Enable showLastPatron 2) Visit two patrons details pages 3) Note "Last patron" link displays and links to the last visited patron 4) Log out 5) Apply this patch 6) Log in 7) Visit the patron details page for a few patrons 8) Note the "Last patron" link behaves as is did previously 9) Note the split button has a pulldown with the other previous patrons 10) Verify that only the last 10 patrons are retained in the pulldown 11) Verify that if you visit a patron who is already in the list they get moved to the top of the list
Created attachment 152980 [details] [review] Bug 21246: Extend the 'Last patron' navigation feature to 'Last 10 patrons' This retains the "last patron" link, but extends it to add a dropdown containg the last 10 patrons. A future enhancement to control how many patrons to retain would complement this well. 1) Enable showLastPatron 2) Visit two patrons details pages 3) Note "Last patron" link displays and links to the last visited patron 4) Log out 5) Apply this patch 6) Log in 7) Visit the patron details page for a few patrons 8) Note the "Last patron" link behaves as is did previously 9) Note the split button has a pulldown with the other previous patrons 10) Verify that only the last 10 patrons are retained in the pulldown 11) Verify that if you visit a patron who is already in the list they get moved to the top of the list Signed-off-by: Sam Lau <samalau@gmail.com>
Testing here: 1) Debugging statement + console.log("HIDDEN BORROWER: " + $("#hiddenborrowernumber").val() ); Looks like a left over debugging statement? 2) Data privacy / functionality concerns I remember when this patch was added there was some dicussion about showing more or less patrons. What I would really like is if we could change the showLastPatron preference from on/off into a pref for configuring the number of patrons to show in the list instead of hardcoding 10. Or have a new pref if that works better? Overall this works very nicely and I'd love to see this!
Created attachment 153849 [details] [review] Bug 21246: Extend the 'Last patron' navigation feature to 'Last 10 patrons' This retains the "last patron" link, but extends it to add a dropdown containg the last 10 patrons. A future enhancement to control how many patrons to retain would complement this well. 1) Enable showLastPatron 2) Visit two patrons details pages 3) Note "Last patron" link displays and links to the last visited patron 4) Log out 5) Apply this patch 6) Log in 7) Visit the patron details page for a few patrons 8) Note the "Last patron" link behaves as is did previously 9) Note the split button has a pulldown with the other previous patrons 10) Verify that only the last 10 patrons are retained in the pulldown 11) Verify that if you visit a patron who is already in the list they get moved to the top of the list Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 153850 [details] [review] Bug 21246: (QA follow-up) Remove debugging statement
Created attachment 153851 [details] [review] Bug 21246: (QA follow-up) Add new syspref to control how many previous patrons are displayed
Created attachment 154011 [details] [review] Bug 21246: Extend the 'Last patron' navigation feature to 'Last 10 patrons' This retains the "last patron" link, but extends it to add a dropdown containg the last 10 patrons. A future enhancement to control how many patrons to retain would complement this well. 1) Enable showLastPatron 2) Visit two patrons details pages 3) Note "Last patron" link displays and links to the last visited patron 4) Log out 5) Apply this patch 6) Log in 7) Visit the patron details page for a few patrons 8) Note the "Last patron" link behaves as is did previously 9) Note the split button has a pulldown with the other previous patrons 10) Verify that only the last 10 patrons are retained in the pulldown 11) Verify that if you visit a patron who is already in the list they get moved to the top of the list Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 154012 [details] [review] Bug 21246: (QA follow-up) Remove debugging statement
Created attachment 154013 [details] [review] Bug 21246: (QA follow-up) Add new syspref to control how many previous patrons are displayed Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Tidied the atomicupdate file. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 154014 [details] [review] Bug 21246: Set ShowLastPatronCount to 1 on update Setting the new preference to 1 will allow us to keep the current behaviour on update. The library can then actively decide to increase the number to whatever they prefer. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x