Created attachment 81168 [details] Error is given for “Unsupported Use attribute” In the advanced cataloging interface, searching LOC and Seattle Public Library for author "Feeney" and title "Sometimes I Lie" results in a record from LOC and "Unsupported Use attribute" error from SPL. (see figure 1 in attached doc) However, the same search using the button "New from Z39.50/SRU" from the basic cataloging interface results in records from LOC and SPL. (see figure 2 in attached doc)
Let's see... The Advanced Editor in cataloguing defines its search attributes in "./koha-tmpl/intranet-tmpl/lib/koha/cateditor/search.js". Title = 1=4 Author = 1=1004 The "New from Z39.50/SRU" defines its attributes in "C4/Breeding.pm". Title = @attr 1=4 Author = @attr 1=1003 We can see the full list of attributes at https://www.loc.gov/z3950/agency/defns/bib1.html#use We can see LOC's supported attributes at http://www.loc.gov/z3950/lcserver.html (which includes 1003 and 1004). I don't see any information about SPL's supported attributes or Z39.50 set up. However, it seems to me that 1004 is an odd choice. I think 1003 tends to be more widely supported.
Created attachment 81249 [details] [review] Bug 21666: Replace unsupported use attribute with more widely supported attribute search.js uses the 1=1004 author personal attribute which isn't supported by libraries like Seattle Public Library. This patch aligns search.js with C4/Breeding.pm which uses the more widely supported 1=1003 author attribute. To test: 1. Set up Seattle Public Library as a Z39.50 target 2. Try to search author using the Advanced Editor advanced search 3. Observe failure 4. Apply the patch 5. Try to search again 6. Observe successful retrieval of records
Created attachment 81250 [details] [review] Bug 21666: Replace unsupported use attribute with more widely supported attribute search.js uses the 1=1004 author personal attribute which isn't supported by libraries like Seattle Public Library. This patch aligns search.js with C4/Breeding.pm which uses the more widely supported 1=1003 author attribute. To test: 1. Set up Seattle Public Library as a Z39.50 target 2. Try to search author using the Advanced Editor advanced search 3. Observe failure 4. Apply the patch 5. Try to search again 6. Observe successful retrieval of records
Switching to Needs Signoff.
(In reply to Katrin Fischer from comment #4) > Switching to Needs Signoff. Thanks, Katrin. I usually use git-bz but the title of this bug used to have non-ASCII characters in it which caused the git-bz editor to fail. Thanks for following that up.
Created attachment 81502 [details] [review] Bug 21666: Replace unsupported use attribute with more widely supported attribute search.js uses the 1=1004 author personal attribute which isn't supported by libraries like Seattle Public Library. This patch aligns search.js with C4/Breeding.pm which uses the more widely supported 1=1003 author attribute. To test: 1. Set up Seattle Public Library as a Z39.50 target 2. Try to search author using the Advanced Editor advanced search 3. Observe failure 4. Apply the patch 5. Try to search again 6. Observe successful retrieval of records Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com>
Created attachment 81532 [details] [review] Bug 21666: Replace unsupported use attribute with more widely supported attribute search.js uses the 1=1004 author personal attribute which isn't supported by libraries like Seattle Public Library. This patch aligns search.js with C4/Breeding.pm which uses the more widely supported 1=1003 author attribute. To test: 1. Set up Seattle Public Library as a Z39.50 target 2. Try to search author using the Advanced Editor advanced search 3. Observe failure 4. Apply the patch 5. Try to search again 6. Observe successful retrieval of records Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Addming my sign-off too - seeing now why my git-bz attach just failed :)
Created attachment 81533 [details] [review] Bug 21666: Replace unsupported use attribute with more widely supported attribute search.js uses the 1=1004 author personal attribute which isn't supported by libraries like Seattle Public Library. This patch aligns search.js with C4/Breeding.pm which uses the more widely supported 1=1003 author attribute. To test: 1. Set up Seattle Public Library as a Z39.50 target 2. Try to search author using the Advanced Editor advanced search 3. Observe failure 4. Apply the patch 5. Try to search again 6. Observe successful retrieval of records Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #8) > Addming my sign-off too - seeing now why my git-bz attach just failed :) Sorry Katrin ;)
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
Pushed to 17.11.x for 17.11.13