Bug 21889 - Include staff interface entered purchase suggestions with system preference MaxOpenSuggestions
Summary: Include staff interface entered purchase suggestions with system preference M...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-27 15:43 UTC by Kelly McElligott
Modified: 2023-10-13 14:55 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly McElligott 2018-11-27 15:43:10 UTC
Currently only Purchase Suggestions made by patrons through the OPAC are the only suggestions counted in the system preference MaxOpenSuggestions.  It would be nice if this system preference also connected to the staff client, so a purchase suggestion done on the patrons account by staff alerted the staff that the patron already had the maximum number of purchase suggestion allowed.  At this time, even if a patron has maxed out the number of open purchase suggestions on the OPAC, a staff member can still enter more purchase suggestions for that patron through the staff client without knowledge of the maxopensuggestions being reached.
Comment 1 Juan 2018-11-30 19:07:45 UTC
Our library currently has a MaxOpenSuggestions limit set in place but found that on the staff side there is no warning when a staff member places another suggestion for a patron and goes over the limit. A simple warning message to alert staff the patron has reached their limit.
Comment 2 Lucas Gass (lukeg) 2022-05-02 20:45:51 UTC
This is still valid, looking into a fix.
Comment 3 Tomás Cohen Arazi (tcohen) 2022-05-03 18:16:30 UTC
(In reply to Lucas Gass from comment #2)
> This is still valid, looking into a fix.

Bug 30663 introduces an option to make the API reject the request because some configurations require override. I think this could be easily implemented using the API and using the 400 - and payload (error_code) to display a modal with a proper message, requiring to confirm the action.
Comment 4 Caroline Cyr La Rose 2023-10-13 14:55:32 UTC
For the moment, I added a note in the manual to specify that the syspref is only for suggestions made by the patron in the OPAC. Just so that people are not surprised when it doesn't do anything in the staff interface.

In the comments (visible only in the 'code' of the manual) I referenced this bug, so when it is fixed, we'll be able to amend the manual.