Bug 35049 - Add ability to choose which status is included in MaxOpenSuggestions
Summary: Add ability to choose which status is included in MaxOpenSuggestions
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-13 13:38 UTC by Caroline Cyr La Rose
Modified: 2024-03-05 21:52 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-10-13 13:38:16 UTC
This is following a discussion between me and Aude on https://gitlab.com/koha-community/koha-manual/-/merge_requests/739

A client asked me if their custom status was included in the count for MaxOpenSuggestions. After testing, I found that only "Pending" suggestions were counted. This was fine with my client as it is what they wanted. But Aude raised the question that maybe some libraries might want their custom statuses to be included in the count. My client did ask me in the inital request that if the suggestions with custom statuses were included in MaxOpenSuggestions, if it was possible to "add an exception" to make it not count...

I think it depends on the workflow of the library. If the status is s step after the suggestion has been analysed and decided upon, it probably should not count in MaxOpenSuggestions. But if it's a status for open suggestions waiting for analysis by another staff member (for example), it probably should count.

I was thinking a system preference might be added, similar to the ILLHiddenRequestStatuses syspref, to let the library choose which statuses count in MaxOpenSuggestions. By default, only 'Pending' counts.

To test:
1. Change MaxOpenSuggestions to 2
2. Go to Adminsitration > Authorized values > SUGGEST_STATUS and add a custom status
3. Log in to the OPAC as a patron
4. Make 2 suggestions
--> A message should indicate that you cannot make any more suggestions as you have reached the maximum permitted
5. In the staff interface, go to Acquisitions > Suggestions
6. Change the status of one of the suggestions to the custom status
7. Go back to the OPAC
--> You should now be able to make a suggestion