Bug 22096 - Missing default values in 'social_data' table
Summary: Missing default values in 'social_data' table
Status: RESOLVED DUPLICATE of bug 22782
Alias: None
Product: Koha
Classification: Unclassified
Component: Database (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-10 16:39 UTC by Tomás Cohen Arazi
Modified: 2019-04-26 22:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2019-01-10 16:39:06 UTC
With strict SQL modes enabled there is a discrepancy in the generated schema files:

diff --git a/Koha/Schema/Result/SocialData.pm b/Koha/Schema/Result/SocialData.pm
index b2d835b..0388635 100644
--- a/Koha/Schema/Result/SocialData.pm
+++ b/Koha/Schema/Result/SocialData.pm
@@ -26,6 +26,7 @@ __PACKAGE__->table("social_data");
 =head2 isbn

   data_type: 'varchar'
+  default_value: (empty string)
   is_nullable: 0
   size: 30

@@ -64,7 +65,7 @@ __PACKAGE__->table("social_data");

 __PACKAGE__->add_columns(
   "isbn",
-  { data_type => "varchar", is_nullable => 0, size => 30 },
+  { data_type => "varchar", default_value => "", is_nullable => 0, size => 30 },
   "num_critics",
   { data_type => "integer", is_nullable => 1 },
   "num_critics_pro",
@@ -92,8 +93,8 @@ __PACKAGE__->add_columns(
 __PACKAGE__->set_primary_key("isbn");


-# Created by DBIx::Class::Schema::Loader v0.07046 @ 2018-11-13 15:24:28
-# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:l44tYFEfIKX0xXzj6AHInQ
+# Created by DBIx::Class::Schema::Loader v0.07042 @ 2019-01-09 05:01:13
+# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:JQqbbM1Yf7tRSgkcyinHIw
Comment 1 Katrin Fischer 2019-04-08 00:28:23 UTC
Tomas, I don't see the problem (might be the time) - is this still valid?
Comment 2 Jonathan Druart 2019-04-26 22:05:01 UTC

*** This bug has been marked as a duplicate of bug 22782 ***