Bug 22133 - Wrong layout in OAI-PMH:archiveID syspref description
Summary: Wrong layout in OAI-PMH:archiveID syspref description
Status: RESOLVED DUPLICATE of bug 21926
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-15 11:26 UTC by Tomás Cohen Arazi
Modified: 2019-01-18 10:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 22133: Wrong layout in OAI-PMH:archiveID syspref description (1.49 KB, patch)
2019-01-15 11:30 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 22133: Wrong layout in OAI-PMH:archiveID syspref description (1.55 KB, patch)
2019-01-15 17:58 UTC, Devinim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2019-01-15 11:26:02 UTC
It looks like this:

"Identify records at this site with the prefix | KOHA-OAI-TEST | : ."

the colon shouldn't be there.
Comment 1 Tomás Cohen Arazi 2019-01-15 11:30:37 UTC
Created attachment 83950 [details] [review]
Bug 22133: Wrong layout in OAI-PMH:archiveID syspref description

This patch fixes a trivial text layout problem on the syspref
description.

To test:
- Search for the OAI-PMH:archiveID syspref on the staff interface
=> FAIL: Notice the colon is placed *after* the input, and looks weird.
- Apply this patch
- Reload the page
=> SUCCESS: The colon is placed *before* the input, and looks more
correct.
- Sign off :-D
Comment 2 Devinim 2019-01-15 17:58:49 UTC
Created attachment 83996 [details] [review]
Bug 22133: Wrong layout in OAI-PMH:archiveID syspref description

This patch fixes a trivial text layout problem on the syspref
description.

To test:
- Search for the OAI-PMH:archiveID syspref on the staff interface
=> FAIL: Notice the colon is placed *after* the input, and looks weird.
- Apply this patch
- Reload the page
=> SUCCESS: The colon is placed *before* the input, and looks more
correct.
- Sign off :-D

Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
Comment 3 David Cook 2019-01-16 00:23:53 UTC
I think the colon might be after the OAI-PMH:archiveID to show that they don't need to include the colon in the value itself?

I've been wondering if it's worth adding the following to the description:
http://www.openarchives.org/OAI/openarchivesprotocol.html#UniqueIdentifier
http://www.openarchives.org/OAI/2.0/guidelines-oai-identifier.htm

I suppose if people are interested in OAI-PMH, they should look it up themselves, but I know it's taken me years to read these documents inside and out.

Maybe we could add something like "E.g. <OAI-PMH:archiveID>:<biblionumber>" to make it more obvious about how the identifier is constructed using this system preference?"
Comment 4 Katrin Fischer 2019-01-16 20:03:34 UTC
I agree with David in that I understand the : as a hint to not enter it. Tomas, could you take a look at comment 3 and comment please?
Comment 5 Tomás Cohen Arazi 2019-01-18 10:37:30 UTC

*** This bug has been marked as a duplicate of bug 21926 ***