Currently, it is possible to comment subscriptions imported from Mana. We need to do the same for reports. Patches coming soon.
Created attachment 84366 [details] [review] Bug 22193: Code refactoring/improvments
Created attachment 84367 [details] [review] Bug 22193: Share report comments Test plan: - apply this patches, - download a report from Mana, - you should see a "Report mistake" button when you show, edit and run this report, - click on Report mistake -> New and type a comment, - check that it appears on the list, - reload the page, check the comment is still in the list, - click on Report mistake -> your comment, - ckeck the count has been incremented, - reload the page, the counter is still the same
Hi Alex, last two lines on test plan don't work for me More than one comments https://screenshots.firefox.com/bUEQMVj2BDVcwhpJ/localhost After reload: back "New" https://screenshots.firefox.com/f65JRGJd5rayY6ll/localhost Mike
Created attachment 84650 [details] [review] Bug 22193: Code refactoring/improvments Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 84651 [details] [review] Bug 22193: Share report comments Test plan: - apply this patches, - download a report from Mana, - you should see a "Report mistake" button when you show, edit and run this report, - click on Report mistake -> New and type a comment, - check that it appears on the list, - reload the page, check the comment is still in the list, - click on Report mistake -> your comment, - ckeck the count has been incremented, - reload the page, the counter is still the same Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment on attachment 84650 [details] [review] Bug 22193: Code refactoring/improvments Review of attachment 84650 [details] [review]: ----------------------------------------------------------------- ::: Koha/SharedContent.pm @@ +141,5 @@ > +sub get_entity_comments { > + my ($resource, $id) = @_; > + > + unless ($id) { > + return []; I would like to see here an implicit undef, so just 'return;'
Created attachment 90349 [details] [review] Bug 22193: QA follow up - return undef instead of an array if no ressource id
sorry, does not apply cleanly on master