Bug 22248 - Error when incrementing Mana comment
Summary: Error when incrementing Mana comment
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Alex Arnaud
QA Contact: Testopia
URL:
Keywords:
Depends on: 17047
Blocks:
  Show dependency treegraph
 
Reported: 2019-01-31 13:39 UTC by Owen Leonard
Modified: 2019-08-02 17:27 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 22248: make svc/mana/increment print valid output (2.32 KB, patch)
2019-06-07 10:34 UTC, Alex Arnaud
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2019-01-31 13:39:28 UTC
When I select an existing Mana comment on a subscription the process completes successfully but in the console this error is returned:


Can't return outside a subroutine at /home/vagrant/kohaclone/svc/mana/increment line 48.

It looks like that script should return JSON.
Comment 1 Alex Arnaud 2019-06-07 10:34:40 UTC
Created attachment 90413 [details] [review]
Bug 22248: make svc/mana/increment print valid output

Test plan:
  - select an existing comment on a subscription
  - check the logs, note the error (Can't return outside a subroutine)
  - apply this patch
  - select an existing comment again
  - error should be gone
Comment 2 Ian Walls 2019-08-02 17:27:51 UTC
I cannot reproduce this error to test.... a POST to http://localhost:8081/cgi-bin/koha/svc/mana/increment returns 200 OK with no content body.  Browser console is happy and quiet.

Perhaps a change on Mana's end?