I don't think this has been mentioned anywhere else? We should probably replace illrequests.borrowernumber with the value from the AnonymousPatron syspref at some point after the request is "done".
I'm not sure about this. How would one recognize that a patron had already requested an item to meet copyright obligations?
Sounds like we need to make it an option that can be turned on or off, then.
Just a note here: When the patron is deleted all the requests will currently be deleted as well. I've filed a bug to suggest we change that to "set NULL": Bug 32630 - Don't delete ILL requests when patron is deleted I think for statistical purposes libraries would like to keep older requests around for at least a while. Maybe a new switch to cleanup_database to delete finished requests older than X days? I've filed: Bug 32629 - Add option for deleting resolved ILL requests to cleanup_database.pl
*** Bug 37901 has been marked as a duplicate of this bug. ***
(In reply to Magnus Enger from comment #0) > I don't think this has been mentioned anywhere else? We should probably > replace illrequests.borrowernumber with the value from the AnonymousPatron > syspref at some point after the request is "done". I think in conjunction with bug 32630: when a patron is deleted, their ILL requests should be kept instead of deleted, and if pseudonymization is enabled the ILL requests should be stored as pseudonymized_transactions for statistical purposes much like checkouts or holds. Does this make sense? Does this deviate from your original thinking @Magnus or is somewhat what the original thinking was? I'm not familiar enough with this part of the code yet to know where AnonymousPatron fits here or if it's a separate thing.
Sounds good to me Pedro. I think this one here would be the next logical step after the other 2: Add something to cleanup_database to anonymize or delete old and completed ILL requests.
(In reply to Katrin Fischer from comment #6) > Sounds good to me Pedro. > > I think this one here would be the next logical step after the other 2: Add > something to cleanup_database to anonymize or delete old and completed ILL > requests. That's bug 32629, right?
(In reply to Tomás Cohen Arazi from comment #7) > (In reply to Katrin Fischer from comment #6) > > Sounds good to me Pedro. > > > > I think this one here would be the next logical step after the other 2: Add > > something to cleanup_database to anonymize or delete old and completed ILL > > requests. > > That's bug 32629, right? Sounds right :)