What is the purpose of RotationPreventTransfers system preference? It is never used in the code. As such, shouldn't it be removed?
Ack.. it looks like during the rebase cycle of the original bug 11897 the use of it got removed :( It should really be implemented rather than removed in my opinion.
I am not sure I can implement it, but I could write a patch to comment it in the yaml file maybe? That way it would not show up for now.
On second thoughts, lets just remove it.. plumbing in the functionality at this stage looks rather challenging.. we could always revisit the feature at a later date once some of the transfers logic has been tidied up a little.
Created attachment 90703 [details] [review] Bug 22653: Remove unimplemented RotationPreventTransfers system preference This removes the RotationPreventTransfers system preference from updated and new installations. To test: - Verify you have the RotationPreventTransfers pref - Apply patch and run database update - Verify the preference no longer exists in your system - in the sys pref editor - in your database: SELECT * from systempreferences WHERE variable = "RotationPreventTransfers";
Thanks for grabbing this one Katrin :)
Created attachment 90720 [details] [review] Bug 22653: Remove unimplemented RotationPreventTransfers system preference This removes the RotationPreventTransfers system preference from updated and new installations. To test: - Verify you have the RotationPreventTransfers pref - Apply patch and run database update - Verify the preference no longer exists in your system - in the sys pref editor - in your database: SELECT * from systempreferences WHERE variable = "RotationPreventTransfers"; Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Going straight to QA for this one.. nice clean patch.. PQA
Nice work! Pushed to master for 19.11.00
I prefer avoid DB changes in stable branches so I don't push to 19.05.x