Just as bug 22761 moves the "Fee receipt" to the ACCOUNT_CREDIT slip, we need to move the "INVOICE" to an ACCOUNT_DEBIT slip.
Created attachment 89115 [details] [review] Bug 22809 - Move "INVOICE" from template to a slip Just as bug 22761 moves the "Fee receipt" to the ACCOUNT_CREDIT slip, we need to move the "INVOICE" to an ACCOUNT_DEBIT slip. Test Plan: 1) Apply this patch set 2) Restart all the things 3) Use the "print" button beside a *fee* 4) You should not see any difference from before the patches were applied
Created attachment 89155 [details] [review] Bug 22809: Move "INVOICE" from template to a slip Just as bug 22761 moves the "Fee receipt" to the ACCOUNT_CREDIT slip, we need to move the "INVOICE" to an ACCOUNT_DEBIT slip. Test Plan: 1) Apply this patch set 2) Restart all the things 3) Use the "print" button beside a *fee* 4) You should not see any difference from before the patches were applied Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 89156 [details] [review] Bug 22809: (QA follow-up) add bug description to atomicupdate Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Also fixed your commit message to make the QA tools happy :D
Created attachment 89229 [details] [review] Bug 22809: Move "INVOICE" from template to a slip Just as bug 22761 moves the "Fee receipt" to the ACCOUNT_CREDIT slip, we need to move the "INVOICE" to an ACCOUNT_DEBIT slip. Test Plan: 1) Apply this patch set 2) Restart all the things 3) Use the "print" button beside a *fee* 4) You should not see any difference from before the patches were applied Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 89230 [details] [review] Bug 22809: (QA follow-up) add bug description to atomicupdate Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 89231 [details] [review] Bug 22809: (QA follow-up) Add notice translations Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Another nice little enhancement.. works well and no obvious regressions. Passing QA
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series