This patch will remove the obsolete "type" attribute from <script> tags in the following acquisitions templates: - intranet-tmpl\prog\en\modules\acqui\basketgroup.tt - intranet-tmpl\prog\en\modules\acqui\parcels.tt - intranet-tmpl\prog\en\modules\acqui\transferorder.tt
Created attachment 90039 [details] [review] Bug 22975: Remove type attribute from script tags: Acquisitions This patch removes the "type" attribute from <script> tags in several acquisitions templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Acquisitions -> Vendors -> Vendor -> Basket groups - Acquisitions -> Vendors -> Vendor -> Receive shipments - Acquisitions -> Vendors -> Vendor -> Basket: In the table of orders, click "Transfer." Transfer an order Validating the HTML source of any of these pages should return no errors related to the "type" attribute.
Created attachment 90056 [details] [review] Bug 22975: Remove type attribute from script tags: Acquisitions This patch removes the "type" attribute from <script> tags in several acquisitions templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Acquisitions -> Vendors -> Vendor -> Basket groups - Acquisitions -> Vendors -> Vendor -> Receive shipments - Acquisitions -> Vendors -> Vendor -> Basket: In the table of orders, click "Transfer." Transfer an order Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 90125 [details] [review] Bug 22975: Remove type attribute from script tags: Acquisitions This patch removes the "type" attribute from <script> tags in several acquisitions templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Acquisitions -> Vendors -> Vendor -> Basket groups - Acquisitions -> Vendors -> Vendor -> Receive shipments - Acquisitions -> Vendors -> Vendor -> Basket: In the table of orders, click "Transfer." Transfer an order Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05