Bug 23450 - Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl
Summary: Display issue and subscription price for each issue in subscription tab of /c...
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Alex Buckley
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on: 23352
Blocks:
  Show dependency treegraph
 
Reported: 2019-08-11 23:05 UTC by Alex Buckley
Modified: 2023-05-19 17:33 UTC (History)
6 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 23450: Display subscription and issue cost in subscription interface of the catalouge/detail.pl (3.24 KB, patch)
2019-08-11 23:07 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 23450: Display subscription and issue cost in subscription interface of the catalouge/detail.pl (6.64 KB, patch)
2019-08-12 07:25 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 23450: Display subscription and issue cost in subscription interface of the catalouge/detail.pl (7.10 KB, patch)
2020-03-27 01:08 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 23450: Display serial and subscription price in biblio detail page (4.56 KB, patch)
2022-01-07 04:13 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 23450: Display serial and subscription price in biblio detail page (4.59 KB, patch)
2022-01-15 14:55 UTC, Samu Heiskanen
Details | Diff | Splinter Review
Bug 23450: Display serial and subscription price in biblio detail page (4.54 KB, patch)
2023-03-12 22:00 UTC, Alex Buckley
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Buckley 2019-08-11 23:05:49 UTC

    
Comment 1 Alex Buckley 2019-08-11 23:07:07 UTC Comment hidden (obsolete)
Comment 2 Alex Buckley 2019-08-12 07:25:12 UTC Comment hidden (obsolete)
Comment 3 Aleisha Amohia 2020-03-27 01:08:47 UTC Comment hidden (obsolete)
Comment 4 Alex Buckley 2022-01-07 04:13:55 UTC Comment hidden (obsolete)
Comment 5 Samu Heiskanen 2022-01-15 14:55:55 UTC
Created attachment 129520 [details] [review]
Bug 23450: Display serial and subscription price in biblio detail page

The 'Subscription' tab should display:
- Total subscription price (based on what's set in the linked order)
- Serial price based on what's set in the 952$g (items.price)

Test plan:
1. Create a subscription
- Tick the 'Create an item record when receiving this serial'
radiobutton
2. Create an order, linking it to a subscription, set:
- Quantity: 2
- Vendor price: 3
3. Receive the serial
4. Set the 952$g (normal purchase price) as 5
5. Visit the biblio detail page
6. View the 'Subscription' tab and confirm that:
'Total subscription cost is: 6.00'
'Issue price' in the table is 5.00

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi>
Comment 6 Jonathan Druart 2022-02-18 11:08:39 UTC
Blocked by bug 23352.
Comment 7 Kyle M Hall 2022-06-10 15:21:53 UTC
A couple points:
A) I'm getting 'Can't call method "unblessed" on an undefined value at /kohadevbox/koha/catalogue/detail.pl line 205' if a subscription has no order related to it
B) There's no need to unbless the order to work with it, just use the object's accessors
Comment 8 Alex Buckley 2023-03-12 22:00:29 UTC
Created attachment 148113 [details] [review]
Bug 23450: Display serial and subscription price in biblio detail page

The 'Subscription' tab should display:
- Total subscription price (based on what's set in the linked order)
- Serial price based on what's set in the 952$g (items.price)

Test plan:
1. Create a subscription
- Tick the 'Create an item record when receiving this serial'
radiobutton
2. Create an order, linking it to a subscription, set:
- Quantity: 2
- Vendor price: 3
3. Receive the serial
4. Set the 952$g (normal purchase price) as 5
5. Visit the biblio detail page
6. View the 'Subscription' tab and confirm that:
- 'Total subscription cost is: 6.00'
- 'Issue price' in the table is 5.00

Sponsored-By: Brimbank Library, Australia
Comment 9 Alex Buckley 2023-03-12 22:00:54 UTC
Ready for testing again.
Comment 10 Sam Lau 2023-05-19 17:33:53 UTC
CONFLICT (content): Merge conflict in C4/Serials.pm