Bug 23501 - Drag-and-drop hold reordering in the staff client
Summary: Drag-and-drop hold reordering in the staff client
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 16421
  Show dependency treegraph
 
Reported: 2019-08-23 14:42 UTC by Owen Leonard
Modified: 2022-01-28 14:48 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 23501: Drag-and-drop hold reordering in the staff client (6.63 KB, patch)
2019-08-23 15:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 23501: Drag-and-drop hold reordering in the staff client (6.66 KB, patch)
2019-08-23 18:39 UTC, Maryse Simard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2019-08-23 14:42:34 UTC
It would be nice to be able to use drag-and-drop to reorder holds in the staff client.
Comment 1 Christopher Brannon 2019-08-23 15:23:42 UTC
+1
Comment 2 Owen Leonard 2019-08-23 15:41:42 UTC Comment hidden (obsolete)
Comment 3 Maryse Simard 2019-08-23 18:39:06 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2019-08-23 21:48:53 UTC
Thank you for the signoff Maryse! I did think of something I wanted to add to this, so I'm going to put it back to "assigned" and submit a follow-up. I want there to be some kind of way to indicate to the user that they have to save their changes after reordering priority.
Comment 5 Christopher Brannon 2019-08-23 23:09:01 UTC
Great idea.  As it is now, that bugs me.  Maybe a banner down at the bottom by the buttons in red text saying changes have not been saved yet?
Comment 6 Owen Leonard 2019-08-24 14:50:57 UTC
(In reply to Christopher Brannon from comment #5)

> Maybe a banner down at the bottom
> by the buttons in red text saying changes have not been saved yet?

I've been puzzling about the text.

"Your changes have not been saved yet" ?

Is that explanatory enough? I'm adding the alert for "Are you sure you want to leave, your changes have not been saved," but browsers don't let you customize the text anymore so it can't specifically mention the hold priority.
Comment 7 Katrin Fischer 2019-09-01 22:35:33 UTC
Could we add one of these warnings when you try to leave the page without saving?

I like that you kept the arrows for now. I wonder if we need the arrows for accessibility of if the priority pull down would be enough.
Comment 8 Christopher Brannon 2019-09-05 14:38:21 UTC
(In reply to Katrin Fischer from comment #7)
> Could we add one of these warnings when you try to leave the page without
> saving?
> 
> I like that you kept the arrows for now. I wonder if we need the arrows for
> accessibility of if the priority pull down would be enough.

I'm thinking that with the pull down we could eliminate either the dropdowns or the arrows, but not both.  If you have a long list, drag and drop might be cumbersome.  At least with the arrows, we could do away with the two arrows that bump the item up or down one position, but we should keep the arrows that bump to the top or bottom of the list.

Thoughts?
Comment 9 Christopher Brannon 2020-01-22 15:27:10 UTC
Another thought...I like the idea of the action menu, but one thing that is needed is to visually see that items are pinned to the bottom.  We don't have that, from what I gather.  I'm thinking, loose the bump up and down arrows, and keep a pushpin on the end.  Have it change color when in use (unless there is a another pushpin in a another position.  That way it visually signals that it is in use.  That would leave just the bump to top and bottom in the action menu.  Personally, my thoughts are that it not THAT cumbersome to just use the dropdown for the numbers.  The scrollbar makes that pretty simple.  BUT, I'm wondering if those two options could be added to the top of the choice of numbers.  For that matter, could Suspend and Cancel be added as well?  Or maybe it is tossing to much at it?  Thoughts?