If 'Actual cost' is entered this should be displayed in the basket
Created attachment 92499 [details] [review] Bug 23522: Show actual price on in baskets To test: 1 - Create a new basket in acq, mark it as 'standing' 2 - Add an item, leave the RRP and Vendor price as 0 3 - Receive shipments for the vendor 4 - Select the title from this basket 5 - On receipt enter an actual cost 6 - Finsih receiving 7 - Go to the basket 8 - Note the total for the order and the basket are 0, keep this browser tab open 9 - Open a new browser tab and create a new non standing basket 10 - Add to basket, again with no RRP or vendor price 11 - Close the basket, receive the item 12 - Enter an actual cost on receipt 13 - Return to view the basket 14 - Total and order are $0 15 - Apply patch 16 - Refresh the basket in both tabs 17 - You now see the actual price for the orders
Created attachment 93000 [details] [review] Bug 23522: Show actual price on in baskets To test: 1 - Create a new basket in acq, mark it as 'standing' 2 - Add an item, leave the RRP and Vendor price as 0 3 - Receive shipments for the vendor 4 - Select the title from this basket 5 - On receipt enter an actual cost 6 - Finsih receiving 7 - Go to the basket 8 - Note the total for the order and the basket are 0, keep this browser tab open 9 - Open a new browser tab and create a new non standing basket 10 - Add to basket, again with no RRP or vendor price 11 - Close the basket, receive the item 12 - Enter an actual cost on receipt 13 - Return to view the basket 14 - Total and order are $0 15 - Apply patch 16 - Refresh the basket in both tabs 17 - You now see the actual price for the orders Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov>
Created attachment 93215 [details] [review] Bug 23522: Show actual price on in baskets To test: 1 - Create a new basket in acq, mark it as 'standing' 2 - Add an item, leave the RRP and Vendor price as 0 3 - Receive shipments for the vendor 4 - Select the title from this basket 5 - On receipt enter an actual cost 6 - Finsih receiving 7 - Go to the basket 8 - Note the total for the order and the basket are 0, keep this browser tab open 9 - Open a new browser tab and create a new non standing basket 10 - Add to basket, again with no RRP or vendor price 11 - Close the basket, receive the item 12 - Enter an actual cost on receipt 13 - Return to view the basket 14 - Total and order are $0 15 - Apply patch 16 - Refresh the basket in both tabs 17 - You now see the actual price for the orders Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
*** Bug 23020 has been marked as a duplicate of this bug. ***
Blocked by dependency bug.
What does that mean? What will it take for the block be cleared? (In reply to Katrin Fischer from comment #5) > Blocked by dependency bug.
(In reply to Michael Sutherland from comment #6) > What does that mean? What will it take for the block be cleared? It means this bug depends on another bug (bug 23523) which is still in the QA process. Once that bug is approved this one can move forward.
Owen -- According to the bug 23523 it was signed off by Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> (In reply to Owen Leonard from comment #7) > (In reply to Michael Sutherland from comment #6) > > What does that mean? What will it take for the block be cleared? > > It means this bug depends on another bug (bug 23523) which is still in the > QA process. Once that bug is approved this one can move forward.
(In reply to Michael Sutherland from comment #8) > Owen -- > > According to the bug 23523 it was signed off Yes, and the next step is for it to be reviewed by a member of the QA team. After that it will be reviewed by the Release Manager.
That's great! Thank you so much! (In reply to Owen Leonard from comment #9) > (In reply to Michael Sutherland from comment #8) > > Owen -- > > > > According to the bug 23523 it was signed off > > Yes, and the next step is for it to be reviewed by a member of the QA team. > After that it will be reviewed by the Release Manager.
Created attachment 95036 [details] [review] Bug 23522: Show actual price on in baskets To test: 1 - Create a new basket in acq, mark it as 'standing' 2 - Add an item, leave the RRP and Vendor price as 0 3 - Receive shipments for the vendor 4 - Select the title from this basket 5 - On receipt enter an actual cost 6 - Finsih receiving 7 - Go to the basket 8 - Note the total for the order and the basket are 0, keep this browser tab open 9 - Open a new browser tab and create a new non standing basket 10 - Add to basket, again with no RRP or vendor price 11 - Close the basket, receive the item 12 - Enter an actual cost on receipt 13 - Return to view the basket 14 - Total and order are $0 15 - Apply patch 16 - Refresh the basket in both tabs 17 - You now see the actual price for the orders Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 95037 [details] [review] Bug 23522: (QA follow-up) Typo fix in comment Tiny typo fix in a new code comment Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Clarifies what's going on behind the scenes by displaying any data we have available to us at the time at which we are looking at the basket. Passing QA
Nice work! Pushed to master for 19.11.00
(In reply to Martin Renvoize from comment #14) > Nice work! > > Pushed to master for 19.11.00 Can this be applied to 19.05.x as well?
enhancement will not be backported to 19.05.x