Bug 6879 - Actual price should show correctly on order line and basket summary
Summary: Actual price should show correctly on order line and basket summary
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-18 20:39 UTC by Katrin Fischer
Modified: 2019-05-04 11:01 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
basket summary page (44.29 KB, image/png)
2011-09-18 20:39 UTC, Katrin Fischer
Details
order line - actual price should be 10.00, as was entered on receive (34.50 KB, image/png)
2011-09-18 20:39 UTC, Katrin Fischer
Details
Use unitprice as the actual cost in neworder (2.08 KB, patch)
2011-09-21 18:23 UTC, Maxime Pelletier
Details | Diff | Splinter Review
actual price on 'received' (25.29 KB, image/png)
2011-10-04 12:29 UTC, Nicole C. Engard
Details
actual price wrong on order line (55.62 KB, image/png)
2011-10-04 12:29 UTC, Nicole C. Engard
Details
[SIGNED-OFF] Use unitprice in neworder so that the value is saved in the database and so it will be the same field used as to receive shipments (2.35 KB, patch)
2011-10-04 13:59 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2011-09-18 20:39:00 UTC
Created attachment 5454 [details]
basket summary page

I found this testing the bug for 4831.
When you enter an actual price receiving items this it the price, that should be accounted as spent in the system. It should also be shown on order line.
It isn't.

To test:
- create new fund
- order item, price 8.74
- receive item, enter actual price 10.00
- search for the title in acq
- check attached screenshots 
  - basket summary page should show actual price somewhere
  - modifying the order line shows the wrong(!) value as actual price
Comment 1 Katrin Fischer 2011-09-18 20:39:38 UTC
Created attachment 5455 [details]
order line - actual price should be 10.00, as was entered on receive
Comment 2 Maxime Pelletier 2011-09-21 18:23:04 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2011-10-04 12:23:03 UTC
Katrin,

What's the URL for the second image you're showing?  

Maxime,

After applying I see the value in the database properly, but I don't see the value on the basket summary page, only on the receipt page.

Nicole
Comment 4 Katrin Fischer 2011-10-04 12:26:26 UTC
The second screenshot is the bottom of the page when you open a po line from the basket summary page for editing.
Comment 5 Nicole C. Engard 2011-10-04 12:29:08 UTC
Created attachment 5688 [details]
actual price on 'received'

The actual price is showing right when I receive an order (and in the unitprice field in the database)
Comment 6 Nicole C. Engard 2011-10-04 12:29:58 UTC
Created attachment 5689 [details]
actual price wrong on order line

The actual price after receiving is still wrong on the edit orderline page (cgi-bin/koha/acqui/neworderempty.pl?ordernumber=16&booksellerid=1)
Comment 7 Nicole C. Engard 2011-10-04 13:59:39 UTC Comment hidden (obsolete)
Comment 8 Nicole C. Engard 2011-10-04 14:03:39 UTC
Ignore my note, this was signed off after 4831 was pushed so it should be okay
Comment 9 Paul Poulain 2011-10-12 10:20:39 UTC
QA comment:

Maxime, I feel your patch is in fact for 6414 and is not related to this 6879.

Am I wrong ? If not, please resubmit at the proper place.
Comment 10 Maxime Pelletier 2011-10-12 14:07:42 UTC
(In reply to comment #9)
> QA comment:
> 
> Maxime, I feel your patch is in fact for 6414 and is not related to this 6879.
> 
> Am I wrong ? If not, please resubmit at the proper place.

I submitted it here because it's half the problem kf reported and I was talking about it on irc. I could submit it for 6414 and this one could be modified to only be an enhancement request to add a column actual price in the basket summary page.
Comment 11 Paul Poulain 2011-10-14 10:12:30 UTC
Comment on attachment 5691 [details] [review]
[SIGNED-OFF] Use unitprice in neworder so that the value is saved in the database and so it will be the same field used as to receive shipments

moved to 6414
Comment 12 Paul Poulain 2011-10-14 10:13:02 UTC
removed the patch status, as there are no more patches attached
Comment 13 Marc Véron 2016-10-02 16:32:16 UTC
Is this bug still valid?
Comment 14 Alex Buckley 2017-12-07 20:31:01 UTC
In Koha 17.11 the actual price added on receival of items is displayed in the order line. 

However the actual price is still not displayed in the basket summary page. 

Another bug with the ordering pricing system is as follows:
1. You accidentally input the incorrect actual value into the receival of the order

2. You modify this actual value by clicking on the order line and writing in a new value

3. Checking the invoices you notice that the old (incorrect) actual value inputted in step 1 is still displayed in the invoice rather than the new actual value inputted in step 2. 

I will be creating a new bug report for this shortly.
Comment 15 Katrin Fischer 2019-05-04 11:01:23 UTC
Ressetting assignee as Mathieu Saby is no longer working on Koha. Needs retesting, last checked 2017.