Bug 24093 - Sorting indicators broken on list contents view
Summary: Sorting indicators broken on list contents view
Status: Pushed to master
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 23013
Blocks:
  Show dependency treegraph
 
Reported: 2019-11-22 18:39 UTC by Owen Leonard
Modified: 2019-11-25 08:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:
19.11.00


Attachments
Bug 24093: Sorting indicators broken on list contents view (5.23 KB, patch)
2019-11-22 18:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 24093: Sorting indicators broken on list contents view (5.28 KB, patch)
2019-11-22 19:59 UTC, Maryse Simard
Details | Diff | Splinter Review
Bug 24093: Sorting indicators broken on list contents view (5.34 KB, patch)
2019-11-22 22:29 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2019-11-22 18:39:40 UTC
Bug 23013 removed some images files which were a dependency for the our previous implementation of DataTables. These image files were being used to indicate the (server-side) sorting direction of the lists contents view.
Comment 1 Owen Leonard 2019-11-22 18:47:16 UTC
Created attachment 95736 [details] [review]
Bug 24093: Sorting indicators broken on list contents view

This patch updates the table markup for the lists contents view so that
the table sort state is correctly indicated by arrows in the table
headers. The markup changes allow the standard DataTables CSS to apply
to this table even though it is not a DataTable.

To test, apply the patch, go to Lists, and view any list with multiple
titles attached.

 - The list should be sorted by default according to the list's
   settings, and the arrow in the header row should correctly reflect
   the sorting column and direction.
 - Test re-sorting the table by each of the different sortable columns,
   confirming each time that the sorting arrows are correct.
Comment 2 Maryse Simard 2019-11-22 19:59:45 UTC
Created attachment 95738 [details] [review]
Bug 24093: Sorting indicators broken on list contents view

This patch updates the table markup for the lists contents view so that
the table sort state is correctly indicated by arrows in the table
headers. The markup changes allow the standard DataTables CSS to apply
to this table even though it is not a DataTable.

To test, apply the patch, go to Lists, and view any list with multiple
titles attached.

 - The list should be sorted by default according to the list's
   settings, and the arrow in the header row should correctly reflect
   the sorting column and direction.
 - Test re-sorting the table by each of the different sortable columns,
   confirming each time that the sorting arrows are correct.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Comment 3 Katrin Fischer 2019-11-22 22:29:32 UTC
Created attachment 95752 [details] [review]
Bug 24093: Sorting indicators broken on list contents view

This patch updates the table markup for the lists contents view so that
the table sort state is correctly indicated by arrows in the table
headers. The markup changes allow the standard DataTables CSS to apply
to this table even though it is not a DataTable.

To test, apply the patch, go to Lists, and view any list with multiple
titles attached.

 - The list should be sorted by default according to the list's
   settings, and the arrow in the header row should correctly reflect
   the sorting column and direction.
 - Test re-sorting the table by each of the different sortable columns,
   confirming each time that the sorting arrows are correct.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Martin Renvoize 2019-11-25 08:44:06 UTC
Nice work!

Pushed to master for 19.11.00