Created attachment 96104 [details] [review]
Bug 24192: Show host record items in basket/shelves

If EasyAnalyticalRecords is enabled, and if record has no items, display
host record items in baskets and lists (staff interface only)

Also, show items.enumchron in both pages

Test plan:
0. Login to staff interface
1. Set EasyAnalyticalRecords to "Display"
2. Create a biblio record without items
3. On the biblio record detail page, click in the menu Edit > Link
to host item, and enter a valid barcode
4. Add the biblio record to your cart
5. Open your cart and verify that the linked item is displayed
6. Add the biblio record to a list
7. Open the list and verify that the linked item is displayed
8. Edit the linked item and enter something that will be saved in
items.enumchron (check the biblio framework mappings, add a new item
field if needed)
9. Re-open your cart and list and verify that the enumchron is shown

I think it might have been nice to split the enumchron into a separate bug - this way it would show up in the release notes.

Followed the test plan but enomchron is not showing

Created attachment 143624 [details] [review]
Bug 24192: Show host record items in basket/shelves

If EasyAnalyticalRecords is enabled, and if record has no items, display
host record items in baskets and lists (staff interface only)

Test plan:
0. Login to staff interface
1. Set EasyAnalyticalRecords to "Display"
2. Create a biblio record without items
3. On the biblio record detail page, click in the menu Edit > Link
to host item, and enter a valid barcode
4. Add the biblio record to your cart
5. Open your cart and verify that the linked item is displayed
6. Add the biblio record to a list
7. Open the list and verify that the linked item is displayed

Rebased on master and removed the parts related to enumchron (this will go in a separate bug)

(In reply to Julian Maurice from comment #4)
> Created attachment 143624 [details] [review] [review]
> Bug 24192: Show host record items in basket/shelves
> 
> If EasyAnalyticalRecords is enabled, and if record has no items, display
> host record items in baskets and lists (staff interface only)
> 
> Test plan:
> 0. Login to staff interface
> 1. Set EasyAnalyticalRecords to "Display"
> 2. Create a biblio record without items
> 3. On the biblio record detail page, click in the menu Edit > Link
> to host item, and enter a valid barcode
> 4. Add the biblio record to your cart
> 5. Open your cart and verify that the linked item is displayed
> 6. Add the biblio record to a list
> 7. Open the list and verify that the linked item is displayed

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Created attachment 147976 [details] [review]
Bug 24192: Show host record items in basket/shelves

If EasyAnalyticalRecords is enabled, and if record has no items, display
host record items in baskets and lists (staff interface only)

Test plan:
0. Login to staff interface
1. Set EasyAnalyticalRecords to "Display"
2. Create a biblio record without items
3. On the biblio record detail page, click in the menu Edit > Link
to host item, and enter a valid barcode
4. Add the biblio record to your cart
5. Open your cart and verify that the linked item is displayed
6. Add the biblio record to a list
7. Open the list and verify that the linked item is displayed

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

I am not sure about limiting this to records with no items. I had a look at other places in the code where host_items is called and we don't seem to use that condition there. (moredetail.pl,  opac-detail.pl, request.pl). 

I think it's quite possible that a record has real items and host items. That happens with bound-withs here quite often.

Maybe I am missing something?

EasyAnalytics is checked in host_items, so that is taken care of.

Also: what about the OPAC equivalents?

Looks like this could use the change from Bug 33496:
Add 'host_items' param to Koha::Biblio->items