Now it has been voted, it needs to be adjusted.
Created attachment 97624 [details] [review] Bug 24462: Adapt mapping to voted RFC (Invoices) This trivial patch changes the attribute names for API reprensentation of Koha::Acquisition::Invoice objects. To test: 1. Open https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC 2. Check the mappings are correct => SUCCESS: The patch makes the right changes to the mappings 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 98277 [details] [review] Bug 24462: Adapt mapping to voted RFC (Invoices) This trivial patch changes the attribute names for API reprensentation of Koha::Acquisition::Invoice objects. To test: 1. Open https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC 2. Check the mappings are correct => SUCCESS: The patch makes the right changes to the mappings 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 98616 [details] [review] Bug 24462: Adapt mapping to voted RFC (Invoices) This trivial patch changes the attribute names for API reprensentation of Koha::Acquisition::Invoice objects. To test: 1. Open https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC 2. Check the mappings are correct => SUCCESS: The patch makes the right changes to the mappings 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
not backported to 19.11.x due to dependencies
Maybe I am missing something, but the invoice API doesn't seem to show on api.koha-community.org. I thought it previously did, but not sure now.
(In reply to Katrin Fischer from comment #6) > Maybe I am missing something, but the invoice API doesn't seem to show on > api.koha-community.org. I thought it previously did, but not sure now. There isn't an invoices API. But they can be embedded on orders.
(In reply to Tomás Cohen Arazi from comment #7) > (In reply to Katrin Fischer from comment #6) > > Maybe I am missing something, but the invoice API doesn't seem to show on > > api.koha-community.org. I thought it previously did, but not sure now. > > There isn't an invoices API. But they can be embedded on orders. Thanks, I'll file some bugs soon.