The naming of “handle_commit_maybe” is very misleading. As far as I can see from comments and old commits, it was intended to do more at some point but all it does, and has ever done, is redirect the user based on some conditions. A better name would be something simpler like “redirect_user”
Created attachment 97678 [details] [review] Bug 24471: handle_commit_maybe => redirect_user This patch renames all occurrences of handle_commit_maybe to redirect_user Test plan: - Navigate around ILL and check redirections from one action/stage to another are happening correctly
Created attachment 115252 [details] [review] Bug 25054: (QA follow-up) Add space after comma for multiple aliases Just a little formatting change to help readability by adding a space after comma: alias1, alias2, ... Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
CONFLICT (content): Merge conflict in ill/ill-requests.pl
+1 to this bug report. I don't think that "maybe" should ever be in a function name...