The naming of “handle_commit_maybe” is very misleading. As far as I can see from comments and old commits, it was intended to do more at some point but all it does, and has ever done, is redirect the user based on some conditions. A better name would be something simpler like “redirect_user”
Created attachment 97678 [details] [review] Bug 24471: handle_commit_maybe => redirect_user This patch renames all occurrences of handle_commit_maybe to redirect_user Test plan: - Navigate around ILL and check redirections from one action/stage to another are happening correctly
Created attachment 115252 [details] [review] Bug 25054: (QA follow-up) Add space after comma for multiple aliases Just a little formatting change to help readability by adding a space after comma: alias1, alias2, ... Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
CONFLICT (content): Merge conflict in ill/ill-requests.pl
+1 to this bug report. I don't think that "maybe" should ever be in a function name...
I have a feeling this is no longer relevant? I've re-assigned to Pedro as our current lead on ILL, but I'd be happy for it to be a simple check and close if the idea if outdated.
Created attachment 168462 [details] [review] Bug 24471: Rename handle_commit_maybe method To test (k-t-d): 1) Enable ILLModule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Checkout 24.05.x branch, run: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout 24.05.x 3) Create a new ILL request from: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 4) Confirm the request creation works as before
Created attachment 168525 [details] [review] Bug 24471: Rename handle_commit_maybe method To test (k-t-d): 1) Enable ILLModule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Checkout 24.05.x branch, run: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout 24.05.x 3) Create a new ILL request from: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 4) Confirm the request creation works as before Signed-off-by: David Nind <david@davidnind.com>
Created attachment 169994 [details] [review] Bug 24471: Rename handle_commit_maybe method To test (k-t-d): 1) Enable ILLModule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Checkout 24.05.x branch, run: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout 24.05.x 3) Create a new ILL request from: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 4) Confirm the request creation works as before Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Moving to enh
Pushed for 24.11! Well done everyone, thank you!
No release notes needed here, just code clean-up. Changing component to "Architecture, internals, and plumbing".