Bug 24471 - Rename ILL method handle_commit_maybe
Summary: Rename ILL method handle_commit_maybe
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-21 16:16 UTC by Andrew Isherwood
Modified: 2023-01-13 13:35 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 24471: handle_commit_maybe => redirect_user (4.18 KB, patch)
2020-01-21 16:20 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 25054: (QA follow-up) Add space after comma for multiple aliases (1.38 KB, patch)
2021-01-18 22:38 UTC, Catherine
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Isherwood 2020-01-21 16:16:22 UTC
The naming of “handle_commit_maybe” is very misleading. As far as I can see from comments and old commits, it was intended to do more at some point but all it does, and has ever done, is redirect the user based on some conditions. A better name would be something simpler like “redirect_user”
Comment 1 Andrew Isherwood 2020-01-21 16:20:10 UTC
Created attachment 97678 [details] [review]
Bug 24471: handle_commit_maybe => redirect_user

This patch renames all occurrences of handle_commit_maybe to
redirect_user

Test plan:

- Navigate around ILL and check redirections from one action/stage to
another are happening correctly
Comment 2 Catherine 2021-01-18 22:38:17 UTC
Created attachment 115252 [details] [review]
Bug 25054: (QA follow-up) Add space after comma for multiple aliases

Just a little formatting change to help readability by adding
a space after comma: alias1, alias2, ...

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Catherine 2021-01-18 22:48:04 UTC
CONFLICT (content): Merge conflict in ill/ill-requests.pl
Comment 4 David Cook 2021-01-18 23:08:21 UTC
+1 to this bug report. I don't think that "maybe" should ever be in a function name...