Resolve things like: Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value $new_data{"overdrive_auth_token"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value $new_data{"streettype"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500.
Created attachment 100955 [details] [review] Bug 24892: Resolve uninitialized warns from opac-memberentry Especially line 500 (current master). Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Trivial fix. Test plan: Do not apply, update from opac memberentry. Check warns in log. Apply patch, update again. Less warns? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial: self signoff
Created attachment 100967 [details] [review] Bug 24892: Resolve uninitialized warns from opac-memberentry Especially line 500 (current master). Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Simple fix, not completely trivial due to adding xor ;) Test plan: Do not apply, update from opac memberentry. Check warns in log. Apply patch, update again. Less warns? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 101055 [details] [review] Bug 24892: Resolve uninitialized warns from opac-memberentry Especially line 500 (current master). Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Simple fix, not completely trivial due to adding xor ;) Test plan: Do not apply, update from opac memberentry. Check warns in log. Apply patch, update again. Less warns? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to Owen Leonard from comment #4) > Signed-off-by: Owen Leonard <oleonard@myacpl.org> Thanks Owen
Created attachment 101115 [details] [review] Bug 24892: Resolve uninitialized warns from opac-memberentry Especially line 500 (current master). Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Simple fix, not completely trivial due to adding xor ;) Test plan: Do not apply, update from opac memberentry. Check warns in log. Apply patch, update again. Less warns? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x for 19.11.05
backported to 19.05.x for 19.05.10
Minor patch will not be backported to 18.11.x series.