(not sure about the bug category) == Test plan == - Install the Kitchen Sink plugin: https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases - (the .kpz) - go to the plugin directory. - example: /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions - edit minimum_version to be above you koha version - go plugin home page - you should see «Warning: This report was written for a newer version of Koha. Run at your own risk.» - this wrong!
When bug 24631 will be in master, the file to edit will be: /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink/PLUGIN.yml
Hi Victor, what should the message be instead?
Found! https://git.koha-community.org/Koha-community/Koha/src/commit/940c0e319a1df9fb2d218d816079b5f5034972f0/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt#L152 > Warning: This plugin was written for an older version of Koha. Run at your own risk.
Created attachment 131517 [details] [review] Bug 25285: Fix wrong message about required Koha version in plugins When you install a plugin that requires a newer Koha version, it reports this: << Warning: This report was written for a newer version of Koha. Run at your own risk. >> It is wrong in a couple ways: - It is not a report. - It feels like it dates back to when plugins were only run i.e. pre-hooks, etc. This patch proposes a change to reflect this. To test: 1. Verify the string changes make sense to you 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 131531 [details] [review] Bug 25285: Fix wrong message about required Koha version in plugins When you install a plugin that requires a newer Koha version, it reports this: << Warning: This report was written for a newer version of Koha. Run at your own risk. >> It is wrong in a couple ways: - It is not a report. - It feels like it dates back to when plugins were only run i.e. pre-hooks, etc. This patch proposes a change to reflect this. To test: 1. Verify the string changes make sense to you 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 131585 [details] [review] Bug 25285: Fix wrong message about required Koha version in plugins When you install a plugin that requires a newer Koha version, it reports this: << Warning: This report was written for a newer version of Koha. Run at your own risk. >> It is wrong in a couple ways: - It is not a report. - It feels like it dates back to when plugins were only run i.e. pre-hooks, etc. This patch proposes a change to reflect this. To test: 1. Verify the string changes make sense to you 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Lol, I've fixed this a few times over the years and it always seems to creep back in somehow. Anywho.. passing QA
Maximum version text was fixed by Bug 21866. This is no enhancement, I change to minor.
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.05