If OPACViewOthersSuggestions is enabled the logged-in user might be viewing a list of suggestions none of which they have permission to delete. If this is the case the "Delete suggested" button should not appear.
Created attachment 103798 [details] [review] Bug 25294: Don't show deletion button if user can't delete suggestions This patch adds logic to the OPAC suggestions template so that when the OPACViewOthersSuggestions system preference is enabled and the logged-in user is viewing other users' suggestions, the "Delete selected" button is only displayed when there are suggestions the user can delete. To test you should have suggestions in your system from at least two users. - Set the OPACViewOthersSuggestions preference to "Show" - Log in to the OPAC as a user who hasn't submitted any suggestions - Go to the suggestions page (with "?suggested_by_anyone=1" appended to the URL if necessary, see Bug 22515). - In the table of suggetions, there should be no titles with a checkbox in the first column. - At the bottom of the table there should be no "Delete selected" button. - Log in to the OPAC as a user with suggestions. - Return to the suggestions page and view all suggestions. - There should be titles with corresponding checkboxes and the "Delete selected" button should appear at the bottom.
Created attachment 103800 [details] [review] Bug 25294: Don't show deletion button if user can't delete suggestions This patch adds logic to the OPAC suggestions template so that when the OPACViewOthersSuggestions system preference is enabled and the logged-in user is viewing other users' suggestions, the "Delete selected" button is only displayed when there are suggestions the user can delete. To test you should have suggestions in your system from at least two users. - Set the OPACViewOthersSuggestions preference to "Show" - Log in to the OPAC as a user who hasn't submitted any suggestions - Go to the suggestions page (with "?suggested_by_anyone=1" appended to the URL if necessary, see Bug 22515). - In the table of suggetions, there should be no titles with a checkbox in the first column. - At the bottom of the table there should be no "Delete selected" button. - Log in to the OPAC as a user with suggestions. - Return to the suggestions page and view all suggestions. - There should be titles with corresponding checkboxes and the "Delete selected" button should appear at the bottom. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 103880 [details] [review] Bug 25294: Don't show deletion button if user can't delete suggestions This patch adds logic to the OPAC suggestions template so that when the OPACViewOthersSuggestions system preference is enabled and the logged-in user is viewing other users' suggestions, the "Delete selected" button is only displayed when there are suggestions the user can delete. To test you should have suggestions in your system from at least two users. - Set the OPACViewOthersSuggestions preference to "Show" - Log in to the OPAC as a user who hasn't submitted any suggestions - Go to the suggestions page (with "?suggested_by_anyone=1" appended to the URL if necessary, see Bug 22515). - In the table of suggetions, there should be no titles with a checkbox in the first column. - At the bottom of the table there should be no "Delete selected" button. - Log in to the OPAC as a user with suggestions. - Return to the suggestions page and view all suggestions. - There should be titles with corresponding checkboxes and the "Delete selected" button should appear at the bottom. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
enhancement not backported to 19.11