Bug 26142 - variable used has hashref when they are objects
Summary: variable used has hashref when they are objects
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Mana-kb (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on: 17047
Blocks:
  Show dependency tree / graph
 
Reported: 2020-08-05 09:49 UTC by Jonathan Druart
Modified: 2020-08-05 09:49 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2020-08-05 09:49:18 UTC 
From commit cb01b253308060bad942723413feef1fd70825fd
     Bug 17047: SQL reports management with Mana-KB

         'notes'      => $report->notes,
         'sql'     => $report->savedsql,
         'showsql' => 1,
+        'mana_success' => $input->param('mana_success'),
+        'mana_success' => scalar $input->param('mana_success'),
+        'mana_id' => $report->{mana_id},
+        'mana_comments' => $report->{comments}

No idea what's the side-effect here but this code is wrong.