Bug 26177 - The 'set library' functionality should be changed to 'session settings' or similar
Summary: The 'set library' functionality should be changed to 'session settings' or si...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on: 24786
Blocks:
  Show dependency treegraph
 
Reported: 2020-08-07 11:45 UTC by Martin Renvoize
Modified: 2021-11-23 08:20 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2020-08-07 11:45:46 UTC
The set library controller and template will soon allow the setting of other session level information like 'desk' and 'cash register'.. as such we should rename and clean up the controller and template to reflect their new functionality.
Comment 1 Martin Renvoize 2020-08-07 11:47:12 UTC
The 'catalogue' permission is a strange one to require as the sole permission to use this functionality
Comment 3 Katrin Fischer 2020-08-07 11:55:36 UTC
I believe we should mimick what happens on the log in screen and not allow to change the library. I think the whole point of indybranches is to keep things separate. If you have central cataloguing, we maybe need a 'super' permission for edit_catalogue like we have in other cases.
Comment 4 David Cook 2020-09-08 23:32:04 UTC
(In reply to Martin Renvoize from comment #0)
> The set library controller and template will soon allow the setting of other
> session level information like 'desk' and 'cash register'.. as such we
> should rename and clean up the controller and template to reflect their new
> functionality.

Sounds good to me.
Comment 5 David Cook 2021-11-22 22:22:15 UTC
Wow I do not recall commenting on this previously but still +1
Comment 6 Tomás Cohen Arazi 2021-11-22 23:23:33 UTC
'Session' might be enough?
Comment 7 David Cook 2021-11-23 00:05:06 UTC
(In reply to Tomás Cohen Arazi from comment #6)
> 'Session' might be enough?

Thinking about this again... I think that "session" is a developer concept that most staff users wouldn't understand. 

I think they're all circulation related so maybe "My circulation settings", although that's a lot of text. Maybe "My location"? Since it would be dealing with their branch, desk, cash register...
Comment 8 Tomás Cohen Arazi 2021-11-23 00:33:49 UTC
(In reply to David Cook from comment #7)
> (In reply to Tomás Cohen Arazi from comment #6)
> > 'Session' might be enough?
> 
> Thinking about this again... I think that "session" is a developer concept
> that most staff users wouldn't understand. 
> 
> I think they're all circulation related so maybe "My circulation settings",
> although that's a lot of text. Maybe "My location"? Since it would be
> dealing with their branch, desk, cash register...

I like 'Location'. The 'My' part of implicit it could be clarified on a drop-down title/header. To understand my opinion, lol at the account info in OPAC and see how redundant it can get!
Comment 9 David Cook 2021-11-23 00:50:16 UTC
(In reply to Tomás Cohen Arazi from comment #8)
> I like 'Location'. The 'My' part of implicit it could be clarified on a
> drop-down title/header. To understand my opinion, lol at the account info in
> OPAC and see how redundant it can get!

Haha. True! I was thinking of keeping it consistent with other items in the dropdown menu but I'm not opposed to dropping the "My".
Comment 10 David Cook 2021-11-23 00:50:57 UTC
(Also, lovely to hear from you, but you should go to sleep!)
Comment 11 Katrin Fischer 2021-11-23 08:20:10 UTC
I am not sure if session would not be understood, location might get confused with locations in items again. What about something generic like "my settings"?
We could imagine using this later for other things like some GUI preferences.