Bug 26403 - "Issue refund" is not fully translatable
Summary: "Issue refund" is not fully translatable
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on: 20307 26418
Blocks: 14825
  Show dependency treegraph
 
Reported: 2020-09-07 21:41 UTC by Katrin Fischer
Modified: 2021-02-25 16:06 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Account summary showing English descriptions (77.60 KB, image/png)
2020-09-09 13:57 UTC, Katrin Fischer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2020-09-07 21:41:18 UTC
The new "issue refund" that is available for payments is not fully translatable. This is a big issue.

To test:
- Make sure a language with a complete translation is installed
- Switch to the language
- Go to any user account
- Add a manual invoice
- Pay it off fully or partially
- Click on "issue refund"
- Verify the list of "Transaction types" is not translated
- Check the information in the patron account. It will show:

Payment from library to patron
A refund applied to a patrons fine

- Check in the OPAC - same issue there.

There is no option to edit the hardcoded credit and debit type descriptions?
Comment 1 Martin Renvoize 2020-09-09 12:37:46 UTC
(In reply to Katrin Fischer from comment #0)
> The new "issue refund" that is available for payments is not fully
> translatable. This is a big issue.
> 
> To test:
> - Make sure a language with a complete translation is installed
> - Switch to the language
> - Go to any user account
> - Add a manual invoice
> - Pay it off fully or partially
> - Click on "issue refund"
> - Verify the list of "Transaction types" is not translated
> - Check the information in the patron account. It will show:
> 
> Payment from library to patron
> A refund applied to a patrons fine
> 
> - Check in the OPAC - same issue there.
> 
> There is no option to edit the hardcoded credit and debit type descriptions?

The reason one cannot edit the descriptions for these hardcoded types is precisely for translation reasons.  If it's a system code it should appear in the translation template and thus the description in the DB will never get called.
Comment 2 Martin Renvoize 2020-09-09 12:50:57 UTC
These are not credit types, but rather the 'payment_type' authorized values... as such to be translatable we need translatable AV's first.... or to merge payment_types into credit_types.. but I'm still not entirely sure about that one.
Comment 3 Katrin Fischer 2020-09-09 13:52:35 UTC
(In reply to Martin Renvoize from comment #2)
> These are not credit types, but rather the 'payment_type' authorized
> values... as such to be translatable we need translatable AV's first.... or
> to merge payment_types into credit_types.. but I'm still not entirely sure
> about that one.

Hm, it was labelled credit types - so maybe the label is wrong then?

But what you are saying is good for the descriptions in the "history" - we "just" need to add them to the templates.
Comment 4 Katrin Fischer 2020-09-09 13:53:48 UTC
I am not sure why this is BLOCKED? We can at least fix a part of this now and we should - translations for authorised values doesn't apply to all points here and it's not around the corner.
Comment 5 Katrin Fischer 2020-09-09 13:57:29 UTC
Created attachment 109816 [details]
Account summary showing English descriptions
Comment 6 Martin Renvoize 2020-09-09 14:23:55 UTC
I've split this bug in two.. one for the description which is fixable and leaving this one here for the transaction type which is blocked by AV translations.