account_credit_types.sql and account_debit_types.sql have been moved to yml files but there are still references to them in C4::Installer. If you select the files during the installer process it will explode with Something went wrong loading file /usr/share/koha/intranet/cgi-bin/installer/data/mysql/mandatory/account_credit_types.sql (Couldn't read '/usr/share/koha/intranet/cgi-bin/installer/data/mysql/mandatory/account_credit_types.sql' : No such file or directory at /usr/share/perl5/DBIx/RunSQL.pm line 180. ) at /usr/share/koha/lib/C4/Installer.pm line 587.
Created attachment 152082 [details] [review] Bug 33935: (bug 26403 follow-up) Remove occurrences to deleted files account_credit_types.sql and account_debit_types.sql have been moved to yml files but there are still references to them in C4::Installer. If you select the files during the installer process it will explode with Test plan: DROP database koha_kohadev CREATE database koha_kohadev restart_all then install Koha using the UI Select all the sample data files
I can't recreate the issue using KTD - nothing explodes after selecting all the sample data and clicking import. (How I reset the database in KTD https://gitlab.com/-/snippets/1893788#start-the-web-installer)
Indeed wrong description it actually does not explode, but there is the error in the plack-intranet-error.log file [WARN] Something went wrong loading file /kohadevbox/koha/installer/data/mysql/mandatory/account_credit_types.sql (Couldn't read '/kohadevbox/koha/installer/data/mysql/mandatory/account_credit_types.sql' : No such file or directory at /usr/share/perl5/DBIx/RunSQL.pm line 180. ) at /kohadevbox/koha/C4/Installer.pm line 588. [WARN] Something went wrong loading file /kohadevbox/koha/installer/data/mysql/mandatory/account_debit_types.sql (Couldn't read '/kohadevbox/koha/installer/data/mysql/mandatory/account_debit_types.sql' : No such file or directory at /usr/share/perl5/DBIx/RunSQL.pm line 180. ) at /kohadevbox/koha/C4/Installer.pm line 588. lowering severity
Created attachment 152099 [details] [review] Bug 33935: (bug 26403 follow-up) Remove occurrences to deleted files account_credit_types.sql and account_debit_types.sql have been moved to yml files but there are still references to them in C4::Installer. If you select the files during the installer process it will explode with Test plan: DROP database koha_kohadev CREATE database koha_kohadev restart_all then install Koha using the UI Select all the sample data files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks for the quick follow-up here Jonathan.. annoyed I missed this one :(
Pushed to master for 23.11. Nice work everyone, thanks!
(In reply to Jonathan Druart from comment #3) > Indeed wrong description it actually does not explode, but there is the > error in the plack-intranet-error.log file Thanks Jonathan!
Nice work everyone! Pushed to oldstable for 22.11.x