Bug 26461 - Incorrect handling of hold levels in SIP2 code
Summary: Incorrect handling of hold levels in SIP2 code
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
: 26842 28311 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-09-14 17:57 UTC by Nick Clemens
Modified: 2021-06-03 23:00 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2020-09-14 17:57:49 UTC
This may need to be split into 2 bugs, but problems are related.

The SIP2 specification lists two fields for holds requests:
AB - item identifier
AJ - title identifier


1 - When placing a hold via SIP we always place a title level hold but only use the 'item identifier' to determine the biblio

2 - When cancelling a hold we use the  'item identifier' to identify the item and will only cancel an item level hold

We should allow the use of the 'title identifier' for placing holds, and we should place an item level hold if 'item identifier' is passed or title level if 'title identifier' is passed with no item identifier

We should do the same for cancelling.
Comment 1 Kyle M Hall 2020-09-16 11:20:34 UTC
This will be a bit messy to fix, but shouldn't be too difficult. Will require changes to ILS.pm, Hold.pm and Item.pm in C4/SIP.

The bigger issue is, should we retain the legacy behavior? If so, we will need a new account parameter.
Comment 2 Kyle M Hall 2020-11-02 15:49:01 UTC
*** Bug 26842 has been marked as a duplicate of this bug. ***
Comment 3 Katrin Fischer 2021-06-03 23:00:41 UTC
*** Bug 28311 has been marked as a duplicate of this bug. ***