To recreate: - turn on cash registers in sysprefs - define at least 2 cash registers in Admin - create a manual invoice on a patron - pay off half of your fee, selecting the first register - pay off the remaining fee, selecting the second register - query accountlines.register_id for your two payments - see that they both show the first register confirmed in master and 19.11.
Verified that the register is recorded incorrectly regardless of which pay button one uses (Pay, Pay Selected, or Pay Amount)
I can also confirm that paying a total line from a different register, other than ID=1, did not log that in the table.
We are very new to community koha (just migrated this past weekend) and this is one of those features that excites us the most since we see the potential to make reporting "End of Day" totals a breeze. We currently have 2 primary locations that take payments that stay separate from each other and it would very helpful to group those locations using these register_id rather than our previous method of searching for all the possible manager_ids that might be taking payments at that location.
Hi Eric, thx for adding more details to this bug report and welcome to the Koha community!
Welcome to the Commmunity Eric. I developed the cash management handling in Koha and we're still refining it with the key stakeholders here so watch this space for further enhancements which may be of interest to you. Thanks for reporting the bug Andrew; I'm on the case now.. if feels like a regression since the original push as I'm confident we tested this functionality back then :(.
Created attachment 110160 [details] [review] Bug 26269: Fix variable name mismatch for cash_register in paycollect It appears that through various rebases the variable names in the form and the controller script have become mismatched. This patch corrects the situation and clarifies their intended use. Test plan: 1/ Turn on cash registers in sysprefs 2/ Define at least 2 cash registers in Admin 3/ Create a manual invoice on a patron 4/ Pay off half of your fee, selecting the first register 5/ Pay off the remaining fee, selecting the second register 6/ Query accountlines.register_id for your two payments 8/ Confirm the two accountlines.register_id's do not match (thus the passed variable was used)
Also rebased bug 24786 atop this.. might be a nice enhancement to test once this one is done.
Created attachment 110173 [details] [review] Bug 26269: Fix variable name mismatch for cash_register in paycollect It appears that through various rebases the variable names in the form and the controller script have become mismatched. This patch corrects the situation and clarifies their intended use. Test plan: 1/ Turn on cash registers in sysprefs 2/ Define at least 2 cash registers in Admin 3/ Create a manual invoice on a patron 4/ Pay off half of your fee, selecting the first register 5/ Pay off the remaining fee, selecting the second register 6/ Query accountlines.register_id for your two payments 8/ Confirm the two accountlines.register_id's do not match (thus the passed variable was used)
Created attachment 110182 [details] [review] Bug 26269: Fix variable name mismatch for cash_register in paycollect It appears that through various rebases the variable names in the form and the controller script have become mismatched. This patch corrects the situation and clarifies their intended use. Test plan: 1/ Turn on cash registers in sysprefs 2/ Define at least 2 cash registers in Admin 3/ Create a manual invoice on a patron 4/ Pay off half of your fee, selecting the first register 5/ Pay off the remaining fee, selecting the second register 6/ Query accountlines.register_id for your two payments 8/ Confirm the two accountlines.register_id's do not match (thus the passed variable was used) https://bugs.koha-community.org/show_bug.cgi?id=26469 Signed-off-by: Jessie Zairo <jzairo@bywatersolutions.com>
Created attachment 110230 [details] [review] Bug 26269: Fix variable name mismatch for cash_register in paycollect It appears that through various rebases the variable names in the form and the controller script have become mismatched. This patch corrects the situation and clarifies their intended use. Test plan: 1/ Turn on cash registers in sysprefs 2/ Define at least 2 cash registers in Admin 3/ Create a manual invoice on a patron 4/ Pay off half of your fee, selecting the first register 5/ Pay off the remaining fee, selecting the second register 6/ Query accountlines.register_id for your two payments 8/ Confirm the two accountlines.register_id's do not match (thus the passed variable was used) https://bugs.koha-community.org/show_bug.cgi?id=26469 Signed-off-by: Jessie Zairo <jzairo@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
Wrong bug number in commit message, caught too late.
That will require manual editing of the release notes!(In reply to Jonathan Druart from comment #12) > Wrong bug number in commit message, caught too late. Note to RMaints: this will require manual editing of the release notes so this fix shows up and not the wrong one!