If a library system has enabled Cash Registers but one branch does not use this. When using the Issue Credit - CASH option from the Accounting Module, an Internal Server Error will occur. 1. Turn on Cash Registers 2. Set up a Cash Register for branch A 3. Log into Branch B and try to issue credit with CASH - this will not work and give an ISE. Other options, such as Check, Credit card, etc will work but not the option for Cash. Understandably, it is because there is not a place for the cash to come from if no cash register is enabled. But I can see this an issue for multi-branch systems where some want to use the Cash register option,but others do not.
Hmm, you are indeed correct and the error is partially deliberate to ensure a cash register is set if the preference is set to use registers. So, are you suggesting that some branches may not want to use registers even though the global preference is set to require them. I'm just trying to understand how to correctly catch when one is missing but should be present... Should one be able to pay out in cash without a register but at a branch that does have at least one register for example? Should the 'UseCashRegisters' preference be set at the branch level? Or, should we just check for the presence of at least one register at a branch and fall into the required mode then? Happy to chat and code it up.
Martin, Thank you for commenting. I would say, making the 'UseCashRegisters' preference be set at the branch level would probably be ideal. Because I can see some branches not using cash registers and this would cause issues.
Created attachment 111137 [details] [review] Bug 26540: Remove 'CASH' type from 'refund' and 'payout' This patch removes the 'CASH' transaction typy, hides the register selection and adds an alert to the Payout and Refund modals on the boraccount page if there are no cash registers yet defined at the for the current branch.
This first patch just adds appropriate alerts and disabled the CASH type from being selected if the branch does not yet have registers associated with it. I'm still contemplating how to set the preference at a branch level.. Options: Set the preference at the branch level so if enabled for a branch but a branch is lacking register definitions we alert and require at least one register to be added... or.. leave the preference at system level but drop the error message for if no registers are defined at a branch yet.
no longer applies cleanly to master
Created attachment 168234 [details] [review] Bug 26540: Remove 'CASH' type from 'refund' and 'payout' This patch removes the 'CASH' transaction typy, hides the register selection and adds an alert to the Payout and Refund modals on the boraccount page if there are no cash registers yet defined at the for the current branch.
Rebased and ready for testing again.
Created attachment 168239 [details] [review] Bug 26540: Remove 'CASH' type from 'refund' and 'payout' This patch removes the 'CASH' transaction type, hides the register selection and adds an alert to the Payout and Refund modals on the boraccount page if there are no cash registers yet defined at the for the current branch. Test plan 1) Enable 'UseCashRegisters' 2) Add a credit to a user account 3) Attempt to 'Issue payout' of the credit to the user and note 3a) A new blue info message appears in the modal letting you know that you cannot issue a payout of type 'Cash' to the user without first adding a cash register. (If you have the correct permissions, you will also see a button in that info box allowing you to add said register) 3b) You will not see either the payment type or registers pulldown in the modal 4) Add at least one new 'PAYMENT_TYPE' authorized value 5) Repeat step 3 5a) Note the blue info message still appears 5b) You may now select a payment type as defined in step 4, however the 'Cash' option is not available. 5c) There is still not an option to select a cash register 6) Add a cash register for your branch 7) Repeat step 3 7a) You will no longer see the blue info box 7b) You should be able to select 'Cash' from the 'Payment type' options 7c) You will be able to select your cash register Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Patch does not apply