Bug 27096 - Add option to message_queue to exclude specific letter codes
Summary: Add option to message_queue to exclude specific letter codes
Status: RESOLVED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 25097
Blocks:
  Show dependency tree / graph
 
Reported: 2020-11-25 20:31 UTC by Andrew Fuerste-Henry
Modified: 2023-12-06 16:21 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2020-11-25 20:31:58 UTC 
Bug 25907 allows one to set process_message_queue to only send notices with the specified letter codes. In some cases, it'd be hand to invert that and list notices to be excluded. So an exclude-list rather than an include-list.
Comment 1 David Cook 2020-11-26 00:22:16 UTC 
(In reply to Andrew Fuerste-Henry from comment #0)
> Bug 25907 allows one to set process_message_queue to only send notices with
> the specified letter codes. In some cases, it'd be hand to invert that and
> list notices to be excluded. So an exclude-list rather than an include-list.

I think you may have made a typo there as Bug 25907 doesn't do that.

I'm interested to hear more though.
Comment 2 Andrew Fuerste-Henry 2020-11-26 00:49:41 UTC 
Oops! Transposed a couple numbers. The correct number is bug 25097.
Comment 3 David Cook 2020-11-26 04:03:39 UTC 
Would it be useful to do this one as a system preference rather than (or in addition to) a command line switch? 

I'm intrigued by Bug 24968. I recently made a local modification to membership_expiry.pl, and I opted to go with a system preference instead, so that that individual libraries could determine some settings. 

It also made it easier from a vendor point of view as we didn't need to mess with any of the existing cronjobs.
Comment 4 Katrin Fischer 2020-11-28 12:40:40 UTC 
I am not sure this one would work as a system preference actually. It allows you to set up different runs of process_message_queue to process different messages. Like you can set it up to process the checkout and checkin notices every 15 minutes, but do all others in a 5 minute interval. That doesn't work in a pref.
Comment 5 David Cook 2020-11-29 22:20:45 UTC 
(In reply to Katrin Fischer from comment #4)
> I am not sure this one would work as a system preference actually. It allows
> you to set up different runs of process_message_queue to process different
> messages. Like you can set it up to process the checkout and checkin notices
> every 15 minutes, but do all others in a 5 minute interval. That doesn't
> work in a pref.

Ahh I understand. Yeah that would be problematic.

What you describe would actually be super useful.
Comment 6 Katrin Fischer 2023-07-01 14:16:08 UTC 
It looks like we have an 'include' option with -t, but not an 'exclude' option still:

This script has the following parameters :
    -u --username: username of mail account
    -p --password: password of mail account
    -t --type: If supplied, only processes this type of message ( email, sms ), repeatable
    -c --code: If supplied, only processes messages with this letter code, repeatable
Comment 7 Andrew Fuerste-Henry 2023-12-06 16:21:03 UTC 
I believe this is made irrelevant by Bug 31453.