Bug 27265 - Process message queue cron should be able to take multiple types as a parameter
Summary: Process message queue cron should be able to take multiple types as a parameter
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 25097
Blocks:
  Show dependency treegraph
 
Reported: 2020-12-17 17:39 UTC by Nick Clemens
Modified: 2021-01-20 12:53 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Text to go in the release notes:
This patch adds the ability to specify several types or letter codes when running the process_message_queue script. This allows libraries to consolidate calls when some message types or letter codes are scheduled differently than others
Version(s) released in:


Attachments
Bug 27265: Enable message queue cron to accept multiple codes and types (3.64 KB, patch)
2020-12-18 13:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 27265: Enable message queue cron to accept multiple codes and types (3.80 KB, patch)
2020-12-18 14:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 27265: Enable message queue cron to accept multiple codes and types (4.52 KB, patch)
2020-12-18 14:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 27265: Enable message queue cron to accept multiple codes and types (4.51 KB, patch)
2021-01-20 12:51 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2020-12-17 17:39:23 UTC
It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines
Comment 1 Kyle M Hall 2020-12-18 13:53:27 UTC
Created attachment 114522 [details] [review]
Bug 27265: Enable message queue cron to accept multiple codes and types

It would be nice to be able to combine several types in a single run,
but exclude others, without having to have multiple cron lines

Test Plan:
1) Apply this patch
2) Run process_message_queue.pl with a single -c parameter
3) Note behavior is unchanged
4) Run process_message_queue.pl with multiple -c parameters
5) Note all the codes specified are processed
6) Repeat 2-5 with -t for type limits
Comment 2 Kyle M Hall 2020-12-18 14:00:50 UTC
Created attachment 114523 [details] [review]
Bug 27265: Enable message queue cron to accept multiple codes and types

It would be nice to be able to combine several types in a single run,
but exclude others, without having to have multiple cron lines

Test Plan:
1) Apply this patch
2) Run process_message_queue.pl with a single -c parameter
3) Note behavior is unchanged
4) Run process_message_queue.pl with multiple -c parameters
5) Note all the codes specified are processed
6) Repeat 2-5 with -t for type limits
Comment 3 Kyle M Hall 2020-12-18 14:02:08 UTC
Created attachment 114525 [details] [review]
Bug 27265: Enable message queue cron to accept multiple codes and types

It would be nice to be able to combine several types in a single run,
but exclude others, without having to have multiple cron lines

Test Plan:
1) Apply this patch
2) Run process_message_queue.pl with a single -c parameter
3) Note behavior is unchanged
4) Run process_message_queue.pl with multiple -c parameters
5) Note all the codes specified are processed
6) Repeat 2-5 with -t for type limits
Comment 4 Andrew Fuerste-Henry 2020-12-23 14:58:24 UTC
This isn't working for me. Here's what I see:
1- have a patron with email enabled for CHECKOUT, CHECKIN notices and an email address on their account
2- check item out to patron, check item in again
3- confirm on patron notices page that they have pending CHECKOUT and CHECKIN notices
4- perl misc/cronjobs/process_message_queue.pl -c CHECKOUT -c CHECKIN
5- notices are not sent
6- perl misc/cronjobs/process_message_queue.pl -c CHECKOUT
7- one notice is sent
Comment 5 Nick Clemens 2021-01-20 12:51:41 UTC
Created attachment 115430 [details] [review]
Bug 27265: Enable message queue cron to accept multiple codes and types

It would be nice to be able to combine several types in a single run,
but exclude others, without having to have multiple cron lines

Test Plan:
1) Apply this patch
2) Run process_message_queue.pl with a single -c parameter
3) Note behavior is unchanged
4) Run process_message_queue.pl with multiple -c parameters
5) Note all the codes specified are processed
6) Repeat 2-5 with -t for type limits