I was rebasing Bug 15565 when I noticed strange Javascript errors. The following code in master was the actual problem: columns_settings_borrowers_table = [% TablesSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] At the moment in koha-testing-docker, this creates the following Javascript: "columns_settings_borrowers_table = " For some reason, this doesn't currently cause a problem because the next line is blank and that line is followed by "$(document).ready(function() {". Anyway, there should be data coming back there, so that's something to investigate...
Created attachment 114660 [details] [review] Bug 27292: Add TablesSettings directive to fix columns_settings_borrowers_table This patch adds the USE TablesSettings directive which allows the plugin to be invoked to fill the columns_settings_borrowers_table variable. Test plan: 0. Do not apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 2. View source on the page and note columns_settings_borrowers_table has no value assigned 2. Apply the patch 3. In a new tab, go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 4. Note that nothing has changed on the surfeace 5. View source ont he page and note columns_settings_borrowers_table now has a value assigned
Thanks for adding that dependency, Owen. That helped a lot. And now a patch for you (or someone else) to test :D
Created attachment 114703 [details] [review] Bug 27292: Add TablesSettings directive to fix columns_settings_borrowers_table This patch adds the USE TablesSettings directive which allows the plugin to be invoked to fill the columns_settings_borrowers_table variable. Test plan: 0. Do not apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 2. View source on the page and note columns_settings_borrowers_table has no value assigned 2. Apply the patch 3. In a new tab, go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 4. Note that nothing has changed on the surfeace 5. View source ont he page and note columns_settings_borrowers_table now has a value assigned Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 114946 [details] [review] Bug 27292: Add TablesSettings directive to fix columns_settings_borrowers_table This patch adds the USE TablesSettings directive which allows the plugin to be invoked to fill the columns_settings_borrowers_table variable. Test plan: 0. Do not apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 2. View source on the page and note columns_settings_borrowers_table has no value assigned 2. Apply the patch 3. In a new tab, go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 4. Note that nothing has changed on the surfeace 5. View source ont he page and note columns_settings_borrowers_table now has a value assigned Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.02
Missing dependencies, not backported to 20.05