Bug 27572 - Move OpacLocationBranchToDisplay system preference into table settings
Summary: Move OpacLocationBranchToDisplay system preference into table settings
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-29 00:27 UTC by Caroline Cyr La Rose
Modified: 2024-03-05 21:52 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2021-01-29 00:27:58 UTC
The OpacLocationBranchToDisplay system preference essentially serves the purpose of hiding or showing columns in the items table in the record details page on the OPAC, namely the home library column and the current library column.

Since we now have Administration > Table settings that we can use to show or hide columns, is this system preference still useful?
Comment 1 Katrin Fischer 2021-01-31 15:05:05 UTC
I think it is because the location shows below the library on a new line and the pref decides if it shows below the home library or below the current library - so the column settings don't work there.

BUT: the pref description is totally wrong at the moment? :(
Comment 2 Katrin Fischer 2023-01-23 23:30:26 UTC
I just tested it and the preference is about the column display, holdingbranch, homebranch or both. I'll change the bug description, I believe this should be moved into column settings.
Comment 3 Caroline Cyr La Rose 2023-04-12 21:09:00 UTC
(In reply to Katrin Fischer from comment #1)
> I think it is because the location shows below the library on a new line and
> the pref decides if it shows below the home library or below the current
> library - so the column settings don't work there.
> 

You're thinking of OpacLocationOnDetail, which is a different one. :)

Currently Administration > Table settings > OPAC > holdingst has the option to show/hide item_current_location	(holding library) and item_home_location (home library), but if we try to show/hide on of the columns using table settings, it doesn't change anything. But if we hide both using table settings, it works.

To test:
1. Set OpacLocationBranchToDisplay to both home and holding library
2. Go to a bibliographic record with an item in the OPAC
   --> Both columns should show
3. Go to Administration > Table settings > OPAC > holdingst and check "Is hidden by default" for item_home_location, save
4. Go to the OPAC and refresh the page
   --> Both columns are still visible
5. Go back to table settings and check also item_current_location (both current and home should now be checked), save
6. Go back to the OPAC and refresh the page
   --> No columns are visible
Comment 4 Owen Leonard 2023-10-11 13:08:39 UTC
If we convert OpacLocationBranchToDisplay to a table setting we should also move the value defined in OPACHoldingsDefaultSortField
Comment 5 Caroline Cyr La Rose 2023-10-11 18:47:49 UTC
(In reply to Owen Leonard from comment #4)
> If we convert OpacLocationBranchToDisplay to a table setting we should also
> move the value defined in OPACHoldingsDefaultSortField

Indeed, that would be logical.