+++ This bug was initially created as a clone of Bug #24897 +++ Now we can translate all installer data, then the fr-FR directory is no longer needed.
Created attachment 121625 [details] [review] Bug 27619: FA for UNIMARC and custom for fr-FR
This did not move recently. On bug 2222 I want to remove auth_subfield_structure.frameworkcode. That gives a lot of changes in especially the fr-FR SQL files. Would you support doing that first ?
(In reply to Marcel de Rooy from comment #2) > This did not move recently. > On bug 2222 I want to remove auth_subfield_structure.frameworkcode. > That gives a lot of changes in especially the fr-FR SQL files. > Would you support doing that first ? Hi Marcel, easy to miss, but there is actually some very recent movement here: This was waiting for the new UNIMARC frameworks (dependency bug 30373). The patches were provided just in time before the hackfest and tests have begun. Once this is solved, it should be relatively easy to resolve this bug.
(In reply to Marcel de Rooy from comment #2) > This did not move recently. > On bug 2222 I want to remove auth_subfield_structure.frameworkcode. > That gives a lot of changes in especially the fr-FR SQL files. > Would you support doing that first ? I cant remove that field. Scratch this remark.
Created attachment 134213 [details] [review] Bug 27619: Add custom for fr-FR
Patches pushed to https://gitlab.com/joubu/Koha/-/commits/bug_27619
(In reply to Jonathan Druart from comment #5) > Created attachment 134213 [details] [review] [review] > Bug 27619: Add custom for fr-FR Hi Jonathan, may be a "DELETE FROM `z3950servers`;" is needed before inserting the BNF server, just in case the sample z3950 servers were selected at install time; or just an "INSERT IGNORE", the BNF server is now present in that archive.
(In reply to Bernardo Gonzalez Kriegel from comment #7) > (In reply to Jonathan Druart from comment #5) > > Created attachment 134213 [details] [review] [review] [review] > > Bug 27619: Add custom for fr-FR > > Hi Jonathan, may be a "DELETE FROM `z3950servers`;" is needed before > inserting the BNF server, just in case the sample z3950 servers were > selected at install time; or just an "INSERT IGNORE", the BNF server is now > present in that archive. Indeed, thanks! I adjusted the remote branch.
Hello, I've just test that one, I can say it works up to some point. After installing translation files and refresh (Clear database) the framework is indeed translated to French. However, it stays in french whatever language I choose for the staff interface. Is this the expected behaviour? (fine for me). If it is then I'm happy to signoff :) Arthur
Can be tested here : https://staff-bz27619.sandboxes.biblibre.eu/cgi-bin/koha/mainpage.pl credentials : koha / XW73vWQpBTN2jVh
(In reply to Arthur Suzuki from comment #9) > Hello, > I've just test that one, I can say it works up to some point. > After installing translation files and refresh (Clear database) the > framework is indeed translated to French. > However, it stays in french whatever language I choose for the staff > interface. > Is this the expected behaviour? (fine for me). > If it is then I'm happy to signoff :) > Arthur Yes, it's totally expected. The installer files are picked according to the language you choose, so if you run the installer in French, the database will be filled with French data. :)
Created attachment 134553 [details] [review] Bug 27619: Add custom for fr-FR Signed-off-by: liliputech <arthur.suzuki@biblibre.com>
Created attachment 134554 [details] [review] Bug 27619: Add custom for fr-FR Signed-off-by: liliputech <arthur.suzuki@biblibre.com> Signed-off-by: liliputech <arthur.suzuki@biblibre.com>
This one has been tested OK! Changing status to SO.
Added Arthur's signed-off-by lines to the remote branch.
This all works as expected to me, but I'm not the target audience in terms of the actual translation workflows.. I'm more the target in terms of streamlining work for devs ;P Feel free to add my SO line on top of Arthurs.. and lets be brave and go for it on this one. Passing QA
Jonathan and I were keen to see this in and watch the test suit/start responding to any issues that present... So, whilst I grabbed the branch to add my QA stamp and went bold and pushed this as an RM Assistant. Thanks to everyone involved, Pushed to Master for 22.05.00!
Created attachment 134861 [details] [review] Bug 27619: (QA follow-up) Remove xt/sample_notices.t Now that we've remove the last of the translated .sql files, we can just drop this test entirely.. translation is now handled on pootle for all languages. Woopie! :) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
*** Bug 30413 has been marked as a duplicate of this bug. ***