Bug 27877 - Accessibility: Staff Client - Reduce heading redundancy
Summary: Accessibility: Staff Client - Reduce heading redundancy
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff Client (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: wainuiwitikapark
QA Contact: Testopia
Keywords: accessibility
Depends on: 27741 27631
Blocks: 28243 28532
  Show dependency treegraph
Reported: 2021-03-05 01:07 UTC by wainuiwitikapark
Modified: 2021-09-30 16:56 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:

Bug 27877: circ/set-library.tt (1.41 KB, patch)
2021-06-09 02:30 UTC, wainuiwitikapark
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description wainuiwitikapark 2021-03-05 01:07:13 UTC
Bug 27631 created <h1> headings on each page of the Staff Client, then Bug 27741 fixed the hierarchy of the other headings in each page to ensure there was no skipping of heading levels, and that items that appeared as headings of some sort, had an <h> tag.

There are now a few headings that are redundant so this bug will deal with issues like this.

Many of the alerts and errors are also tagged as headings, which for many cases is not correct. Therefore, this bug will also deal with these issues
Comment 1 wainuiwitikapark 2021-04-07 02:27:11 UTC
I don't think this bug needs to address error alerts anymore
Comment 2 wainuiwitikapark 2021-06-09 01:54:24 UTC
Files I specifically noticed may have redundancy:

Comment 3 wainuiwitikapark 2021-06-09 02:21:01 UTC
The only file/page I noticed unnecessary was circ/set-library.tt

Adding patch to amend this now...

Please let me know if you notice anymore redundant headings that have appeared because of my accessibility heading fixes.
Comment 4 wainuiwitikapark 2021-06-09 02:30:48 UTC
Created attachment 121725 [details] [review]
Bug 27877: circ/set-library.tt

Got rid of heading redundancy

To test:
1) Apply patch and dependencies
2) Go to Staff Client
3) Go to circ/set-library
4) Check that there are no visible unnecessary redundant/repeated headings
5) Check that there is a legend that has the class "sr-only" which
eliminates visible redundancy but leaves descriptions for those who use screen readers

Sponsored-by: Catalyst IT
Comment 5 Hakam Almotlak 2021-06-22 12:45:15 UTC
Could you just explain the problem before the patch please so we can see the difference between the code before and after?