The 'This sale' table on the point of sale page is currently sorted by price by default. This can cause unexpected sorting when updating prices and quantities.. as such, we should remove the default sort.
Created attachment 117278 [details] [review] Bug 27776: Remove default sort order of sales table This patch drops the default sort on table initialisation so that the table remains sorted in the order in which items are added unless the user explicitly chooses to apply a sort order. We also correct a mistake in the targets for disabling sorting on the 'Actions' column and update the hidden 'CODE' column to use the same syntax as the other definitions for consistency. Test plan 1/ Enable the point of sale system and set some debit types to allow sale. 2/ Navigate to the point of sale page and added some items to sell 3/ Update the price for a few lines and note the sort order does not change. 4/ Update the quantity for a few lines and note the sort order does not change. 5/ Sort a column using the headers and note it works 6/ Signoff
Given the status of Bug 25777 I think you should probably take out the changes to the DataTables option names which aren't directly related to the patch's functionality: - "targets": [-1], - "visible": false, - "searchable": false + "aTargets": [-1], + "bVisible": false, + "bSearchable": false,
Created attachment 117364 [details] [review] Bug 27776: Remove default sort order of sales table This patch drops the default sort on table initialisation so that the table remains sorted in the order in which items are added unless the user explicitly chooses to apply a sort order. We also correct a mistake in the targets for disabling sorting on the 'Actions' column and update the hidden 'CODE' column to use the same syntax as the other definitions for consistency. Test plan 1/ Enable the point of sale system and set some debit types to allow sale. 2/ Navigate to the point of sale page and added some items to sell 3/ Update the price for a few lines and note the sort order does not change. 4/ Update the quantity for a few lines and note the sort order does not change. 5/ Sort a column using the headers and note it works 6/ Signoff
Thanks Owen, I hadn't realised that trying to move towards consistency within a file had become so contentious :(. Fixed the patch ad re-attached.
Created attachment 117668 [details] [review] Bug 27776: Remove default sort order of sales table This patch drops the default sort on table initialisation so that the table remains sorted in the order in which items are added unless the user explicitly chooses to apply a sort order. We also correct a mistake in the targets for disabling sorting on the 'Actions' column and update the hidden 'CODE' column to use the same syntax as the other definitions for consistency. Test plan 1/ Enable the point of sale system and set some debit types to allow sale. 2/ Navigate to the point of sale page and added some items to sell 3/ Update the price for a few lines and note the sort order does not change. 4/ Update the quantity for a few lines and note the sort order does not change. 5/ Sort a column using the headers and note it works 6/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Works perfectly - signed off.
Created attachment 117699 [details] [review] Bug 27776: Remove default sort order of sales table This patch drops the default sort on table initialisation so that the table remains sorted in the order in which items are added unless the user explicitly chooses to apply a sort order. We also correct a mistake in the targets for disabling sorting on the 'Actions' column and update the hidden 'CODE' column to use the same syntax as the other definitions for consistency. Test plan 1/ Enable the point of sale system and set some debit types to allow sale. 2/ Navigate to the point of sale page and added some items to sell 3/ Update the price for a few lines and note the sort order does not change. 4/ Update the quantity for a few lines and note the sort order does not change. 5/ Sort a column using the headers and note it works 6/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.04
Pushed to 20.05.x for 20.05.10
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.
*** Bug 28060 has been marked as a duplicate of this bug. ***