I understand the need to not allow code editing once a code has been created for tables. However, I am wondering if we could consider another approach. It is risky, but might provide more flexibility with editing. This would be particularly helpful to those of us that mistype a code, or create a code, only to realize that sorting in dropdowns is based on order of the code, not the description. What if we added an option to change the code, and the process would A) check related tables to make sure the suggested change doesn't already exist, and B) change all instances of that code in related tables. If there are flaws with this process, or it is too risky, I understand. I am just one of those people that hates it when you make a mistake and then it lives in your database for eternity.
Created attachment 117866 [details] [review] Bug 27881: Markup error in masthead-langmenu.inc Some markup errors were introduced into the masthead-langmenu include file by Bug 20168, presumably during the update to the dropdown menu markup: '<a class="dropdown-item" <a href="' ...resulting in validation errors like "Attribute <a not allowed on element a at this point." This patch correct the errors. To test you should have at least two languages enabled in the OPACLanguages system preference, opaclanguagesdisplay set to "allow," and OpacLangSelectorMode set to "top" or "both top and footer." - Apply the patch and view the OPAC. - The "Languages" menu at the top of the page should look correct and work correctly. - Validating the source of the page should return no errors related to the language menu's markup.
Sorry for the noise -- attach this patch to the wrong bug.
I think it would be quite hard to do in some cases. If we had FK constraints in the database a lot of the change could be handled automatically, but we are not quite there yet. At least for item type codes this could work, I think Not sure about authorised values - they are used so differently in so many tables that it would probably be a lot more risky to get this to work reliably. On the other hand - those codes can already be changed.