masthead-langmenu.inc has a few instances of this error: <a class="dropdown-item"<a href="#" tabindex="-1" class="menu-inactive" role="menuitem">
Created attachment 117873 [details] [review] Bug 27881: Markup error in masthead-langmenu.inc Some markup errors were introduced into the masthead-langmenu include file by Bug 20168, presumably during the update to the dropdown menu markup: '<a class="dropdown-item" <a href="' ...resulting in validation errors like "Attribute <a not allowed on element a at this point." This patch correct the errors. To test you should have at least two languages enabled in the OPACLanguages system preference, opaclanguagesdisplay set to "allow," and OpacLangSelectorMode set to "top" or "both top and footer." - Apply the patch and view the OPAC. - The "Languages" menu at the top of the page should look correct and work correctly. - Validating the source of the page should return no errors related to the language menu's markup.
*** Bug 27888 has been marked as a duplicate of this bug. ***
As I filed a duplicate, least I can do is a sign-off... :)
Created attachment 117877 [details] [review] Bug 27881: Markup error in masthead-langmenu.inc Some markup errors were introduced into the masthead-langmenu include file by Bug 20168, presumably during the update to the dropdown menu markup: '<a class="dropdown-item" <a href="' ...resulting in validation errors like "Attribute <a not allowed on element a at this point." This patch correct the errors. To test you should have at least two languages enabled in the OPACLanguages system preference, opaclanguagesdisplay set to "allow," and OpacLangSelectorMode set to "top" or "both top and footer." - Apply the patch and view the OPAC. - The "Languages" menu at the top of the page should look correct and work correctly. - Validating the source of the page should return no errors related to the language menu's markup. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 118810 [details] [review] Bug 27881: Markup error in masthead-langmenu.inc Some markup errors were introduced into the masthead-langmenu include file by Bug 20168, presumably during the update to the dropdown menu markup: '<a class="dropdown-item" <a href="' ...resulting in validation errors like "Attribute <a not allowed on element a at this point." This patch correct the errors. To test you should have at least two languages enabled in the OPACLanguages system preference, opaclanguagesdisplay set to "allow," and OpacLangSelectorMode set to "top" or "both top and footer." - Apply the patch and view the OPAC. - The "Languages" menu at the top of the page should look correct and work correctly. - Validating the source of the page should return no errors related to the language menu's markup. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good catch, Passing QA
Pushed to master for 21.05, thanks to everybody involved!
This problem is also present in 20.11, I just verified on our test installation - could this be backported?
Pushed to 20.11.x for 20.11.05
Missing dependency, not backported