Bug 34646 - Two attributes class in OPAC masthead-langmenu.inc
Summary: Two attributes class in OPAC masthead-langmenu.inc
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 27881
Blocks:
  Show dependency treegraph
 
Reported: 2023-08-29 17:57 UTC by Fridolin Somers
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10


Attachments
Bug 34646: Fix two attributes class in OPAC masthead-langmenu.inc (1.71 KB, patch)
2023-08-29 18:11 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 34646: Fix two attributes class in OPAC masthead-langmenu.inc (1.76 KB, patch)
2023-08-30 11:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34646: Fix two attributes class in OPAC masthead-langmenu.inc (1.86 KB, patch)
2023-09-01 07:46 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-08-29 17:57:08 UTC
In OPAC template masthead-langmenu.inc a link as two class attributes :
  <a class="dropdown-item" href="#" tabindex="-1" class="menu-inactive" role="menuitem">
Comment 1 Fridolin Somers 2023-08-29 18:11:57 UTC
Created attachment 154915 [details] [review]
Bug 34646: Fix two attributes class in OPAC masthead-langmenu.inc

In OPAC template masthead-langmenu.inc a link as two class attributes :
  <a class="dropdown-item" href="#" tabindex="-1" class="menu-inactive" role="menuitem">

Test plan :
1) Go to OPAC with at least one translation
2) Look at HTML source code
=> Without patch you see a link with 2 class attributes
=> With patch you see the 2 classes in same class attribute
Comment 2 Owen Leonard 2023-08-30 11:02:07 UTC
Created attachment 154945 [details] [review]
Bug 34646: Fix two attributes class in OPAC masthead-langmenu.inc

In OPAC template masthead-langmenu.inc a link as two class attributes :
  <a class="dropdown-item" href="#" tabindex="-1" class="menu-inactive" role="menuitem">

Test plan :
1) Go to OPAC with at least one translation
2) Look at HTML source code
=> Without patch you see a link with 2 class attributes
=> With patch you see the 2 classes in same class attribute

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2023-09-01 07:46:42 UTC
Created attachment 155054 [details] [review]
Bug 34646: Fix two attributes class in OPAC masthead-langmenu.inc

In OPAC template masthead-langmenu.inc a link as two class attributes :
  <a class="dropdown-item" href="#" tabindex="-1" class="menu-inactive" role="menuitem">

Test plan :
1) Go to OPAC with at least one translation
2) Look at HTML source code
=> Without patch you see a link with 2 class attributes
=> With patch you see the 2 classes in same class attribute

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi 2023-09-01 14:25:05 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-09-08 05:54:58 UTC
Pushed to 23.05.x for 23.05.04
Comment 6 Matt Blenkinsop 2023-09-15 09:34:02 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x