Bug 28068 - Cash register should not record writeoff as cash received
Summary: Cash register should not record writeoff as cash received
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: 20.05
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-31 21:06 UTC by Esther Melander
Modified: 2023-06-08 22:26 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Write off error (18.81 KB, image/png)
2021-03-31 21:19 UTC, Esther Melander
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Esther Melander 2021-03-31 21:06:40 UTC
While reviewing register details I found that write offs are recorded as cash received. Unless I misunderstand write-offs, no cash is received but is meant to act as a type of forgiveness. This is confusing because it adds to the total cash received in the cash register. The register summary excludes the write off in the total bankable, but without knowing why there is a difference between the total received and bankable it can lead to confusion.

The current summary (example):
Last cashup: 03/30/2021 01:28 PM
Float: 25.00
Total income (cash): 68.95 (68.40)
Total outgoing (cash): -5.10 (-5.10)
Total bankable: 63.30

Proposed change (example):
Last cashup: 03/30/2021 01:28 PM
Float: 25.00
Total income (cash): 68.95 (68.40)
Total outgoing (cash): -5.10 (-5.10)
Total write-offs: -0.55
Total bankable: 63.30

Or even better, do not include write-offs as cash received since no money enters the drawer during that transaction.
Comment 1 Esther Melander 2021-03-31 21:19:57 UTC
Created attachment 119061 [details]
Write off error

Looking closer at my write off example, the total added to the drawer does not make sense. I've attached a screen shot.

The lost item was automatically credited ($10.00) to the patron because the item was returned. The two remaining fines were written off and totaled $0.85. So where did the $0.55 come from?
Comment 2 Nick Clemens (kidclamp) 2021-11-04 07:34:06 UTC
Fixed in master by 24786

Before that bug, we had:
 80 my $cash_register_id;
 81 if ( C4::Context->preference('UseCashRegisters') ) {
 82     $cash_register_id = $input->param('cash_register');
...
 93         if ( !$cash_register_id ) {
 94             my $default_register = Koha::Cash::Registers->find(
 95                 { branch => $library_id, branch_default => 1 } );
 96             $cash_register_id = $default_register->id if $default_register;
 97         }
 98         $cash_register_id = $registers->next->id if !$cash_register_id;


Which would set the cash register even for a write-off

After that patch we get the value from the template - and don't set it for WRITEOFF
Comment 3 Katrin Fischer 2022-06-25 21:47:57 UTC
(In reply to Nick Clemens from comment #2)
> Fixed in master by 24786
> 
> Before that bug, we had:
>  80 my $cash_register_id;
>  81 if ( C4::Context->preference('UseCashRegisters') ) {
>  82     $cash_register_id = $input->param('cash_register');
> ...
>  93         if ( !$cash_register_id ) {
>  94             my $default_register = Koha::Cash::Registers->find(
>  95                 { branch => $library_id, branch_default => 1 } );
>  96             $cash_register_id = $default_register->id if
> $default_register;
>  97         }
>  98         $cash_register_id = $registers->next->id if !$cash_register_id;
> 
> 
> Which would set the cash register even for a write-off
> 
> After that patch we get the value from the template - and don't set it for
> WRITEOFF

Bug 24786 is in 20.11, so it should be ok in all maintained versions.