Created attachment 120176 [details] [review] Bug 28228: Supress plugin related error message Use of uninitialized value in subroutine entry at /usr/share/koha/lib/Koha/Plugins/Base.pm line 182. Test Plan: 1) Install the Kitchen Sink plugin ( it does not have a max versio defined ) 2) Note the warning in your logs 3) Apply this patch 4) Restart all the things 5) No warning!
Created attachment 124789 [details] [review] Bug 28228: Supress plugin related error message Use of uninitialized value in subroutine entry at /usr/share/koha/lib/Koha/Plugins/Base.pm line 182. Test Plan: 1) Install the Kitchen Sink plugin ( it does not have a max versio defined ) 2) Note the warning in your logs 3) Apply this patch 4) Restart all the things 5) No warning! Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
*** Bug 27161 has been marked as a duplicate of this bug. ***
I don't see how this patch does anything, and thus unable to even reproduce the problem. The problem should have been fixed already by "Bug 24361: (bug 24217 follow-up) Fix several warnings in C4 modules". Is the information about this concering master branch correct? The $metadata->{$_} part is false if it is undef so it should not proceed to the next statement.
Created attachment 124795 [details] [review] Bug 28228: Supress plugin related error message Use of uninitialized value in subroutine entry at /usr/share/koha/lib/Koha/Plugins/Base.pm line 182. Test Plan: 1) Install the Kitchen Sink plugin ( it does not have a max versio defined ) 2) Note the warning in your logs 3) Apply this patch 4) Restart all the things 5) No warning! Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
It at least fixes the strings where they evaluate to false, like 0, so this is still a good patch to take in but I don't see still how this fixes any warnings.
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Pushed to 20.11.x for 20.11.11