We are missing some changes in the mappings.yaml file: * missing staff_client/opac (bug 25325 and bug 20589) * missing mandatory (bug 19482) * sort (bug 27316) became a boolean field Which means export_elasticsearch_mappings.pl generates a file that differs a lot from the one we have in our codebase.
*** Bug 27856 has been marked as a duplicate of this bug. ***
Created attachment 120405 [details] [review] Bug 28279: Re-sync mappings.yaml We are missing some changes in the mappings.yaml file: * missing staff_client/opac (bug 25325 and bug 20589) * missing mandatory (bug 19482) * sort (bug 27316) became a boolean field Which means export_elasticsearch_mappings.pl generates a file that differs a lot from the one we have in our codebase. There are also indentation changes certainly caused by the replacement of YAML with YAML::XS Test plan: 1. reset_all without this patch 2. export the mappings to a non-tracked file (ie. don't erate mappings.yaml from source) 3. Apply this patch 4. Compare both file => No change expected 5. Reset the mappings (so using the mappings.yaml after the changes from this patch) 6. Compare the tables on the UI (with and without the patch applied) => No change expected QA will use --word-diff to make sure only mandatory, sort and staff_client/opac are modified
Sorry patch does not apply anymore
Created attachment 123868 [details] [review] Bug 28279: Re-sync mappings.yaml We are missing some changes in the mappings.yaml file: * missing staff_client/opac (bug 25325 and bug 20589) * missing mandatory (bug 19482) * sort (bug 27316) became a boolean field Which means export_elasticsearch_mappings.pl generates a file that differs a lot from the one we have in our codebase. There are also indentation changes certainly caused by the replacement of YAML with YAML::XS Test plan: 1. reset_all without this patch 2. export the mappings to a non-tracked file (ie. don't erate mappings.yaml from source) 3. Apply this patch 4. Compare both file => No change expected 5. Reset the mappings (so using the mappings.yaml after the changes from this patch) 6. Compare the tables on the UI (with and without the patch applied) => No change expected QA will use --word-diff to make sure only mandatory, sort and staff_client/opac are modified
There is a strange thing in the patch. Some blocks are moving (for example field Heading). Looks like the export sorts by MARC type marc21->unimarc->normarc. But for me export sorts by MARC type alphabetical : marc21->normarc->unimarc. This is in patch : Bug 23204: Fix ordering of fields in exported file o_O
I've only used export_elasticsearch_mappings.pl to generate this patch.
Ah, I think we need someone else testing. Maybe Nick.
Has been regenerated by commit 0760045e0b10a80643b90cac77f653d5cda42e75 Bug 18984: Remove ES mapping for NORMARC