Bug 28310 - request.pl using biblioitemnumber in biblionumber field
Summary: request.pl using biblioitemnumber in biblionumber field
Status: RESOLVED DUPLICATE of bug 28057
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Blou
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-10 15:49 UTC by Blou
Modified: 2021-05-10 17:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 28310: request.pl using biblioitemnumber in biblionumber field (1.38 KB, patch)
2021-05-10 15:51 UTC, Blou
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Blou 2021-05-10 15:49:33 UTC
In reserve/request.pl, the code querying ItemsAnyAvailableAndNotRestricted (previously ItemsAnyAvailableForHold) is passing the biblioitemnumber as a value to a specified biblionumber.

ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitemnumber, patron => $patron })

All you need is a Koha instance where the values of biblionumber and biblioitemnumber being different for this to break.  And break badly.

This occurs in 20.05+
Comment 1 Blou 2021-05-10 15:51:34 UTC
Created attachment 120800 [details] [review]
Bug 28310: request.pl using biblioitemnumber in biblionumber field

In reserve/request.pl, the code querying ItemsAnyAvailableAndNotRestricted (previously ItemsAnyAvailableForHold)
is passing the biblioitemnumber as a value to a specified biblionumber.

>> ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitemnumber, patron => $patron })

All you need is a Koha instance where the values of biblionumber and biblioitemnumber are not synchronized for this to break.  And break badly.
Comment 2 Owen Leonard 2021-05-10 16:27:41 UTC
Is this a duplicate of Bug 28057?
Comment 3 Blou 2021-05-10 17:09:48 UTC
As Owen said, duplicate

*** This bug has been marked as a duplicate of bug 28057 ***