If you issue a refund for an charge and then view the transactions on the register page, you currently have no way of displaying what the refund was against.
Created attachment 121175 [details] [review] Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management.
Created attachment 121189 [details] [review] Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This works well and should defenitly come in handy!
Just wondering about this kind of naming: debit.credit.description
<td>[%- PROCESS account_type_description account=debit.credit -%]</td> [%- IF debit.credit.description %][% debit.credit.description | html %][%- END -%] [%- IF ( debit.credit.itemnumber ) -%] (<a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% debit.credit.item.biblionumber | uri %]&itemnumber=[% debit.credit.itemnumber | uri %]">[% debit.credit.item.biblio.title | html %]</a>)[%- END -%] <td>[% debit.credit.amount | $Price %]</td> This does not look good to me at first glance. You remove <td> and move data outside data tags? Please explain/correct.
Created attachment 123477 [details] [review] Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management. Test plan 1/ Enable 'UseCashRegisters' 2/ Add some transactions with at least one including a 'Refund' 3/ Look at the transaction history for the current register (Tools > Cash management > Transaction history for X) 4/ Note the refund line does not contain a link to 'Details' 5/ Apply the patch 6/ The refund line should now have a 'Details' button on the right. 7/ Bonus points, perform a cashup and then search for older transactions and check the 'Details' button appears in this table too. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(In reply to Marcel de Rooy from comment #5) > <td>[%- PROCESS account_type_description > account=debit.credit -%]</td> > [%- IF debit.credit.description %][% > debit.credit.description | html %][%- END -%] > [%- IF ( debit.credit.itemnumber ) -%] > (<a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% > debit.credit.item.biblionumber | uri %]&itemnumber=[% > debit.credit.itemnumber | uri %]">[% debit.credit.item.biblio.title | html > %]</a>)[%- END -%] > <td>[% debit.credit.amount | $Price %]</td> > > This does not look good to me at first glance. > You remove <td> and move data outside data tags? > Please explain/correct. Good catch, my brain was clearly on a go slow there. I've rebased the patch, added a more details test plan and fixed an additional error with regards the historical transactions table not adding this field.
Created attachment 123479 [details] [review] Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management. Test plan 1/ Enable 'UseCashRegisters' 2/ Add some transactions with at least one including a 'Refund' 3/ Look at the transaction history for the current register (Tools > Cash management > Transaction history for X) 4/ Note the refund line does not contain a link to 'Details' 5/ Apply the patch 6/ The refund line should now have a 'Details' button on the right. 7/ Bonus points, perform a cashup and then search for older transactions and check the 'Details' button appears in this table too. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 126023 [details] [review] Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management. Test plan 1/ Enable 'UseCashRegisters' 2/ Add some transactions with at least one including a 'Refund' 3/ Look at the transaction history for the current register (Tools > Cash management > Transaction history for X) 4/ Note the refund line does not contain a link to 'Details' 5/ Apply the patch 6/ The refund line should now have a 'Details' button on the right. 7/ Bonus points, perform a cashup and then search for older transactions and check the 'Details' button appears in this table too. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!