The rowGrouped table for listing transactions taken against a cash register had 'timestamp' added for display in bug 28127. This his great, however; * The timestamp added is at the individual line level and not the grouped transaction level. This means that for a payment we're actually displaying the times at which each debt was created and not the time the payment was made. This is OK for POS sales, as they will always match the Payment time (though it does look odd having duplicates).. but for payments made against a patrons account that can also appear on these pages it could get quite confusing and misleading. I propose that we use the payment line timestamp instead and move it to the grouping header row.
Created attachment 121179 [details] [review] Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display
Created attachment 121187 [details] [review] Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Thanks Martin. Looks nicer, functions better.
Martin, Any chance for a rebase of this one?
Created attachment 123422 [details] [review] Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 123478 [details] [review] Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Another minor rebase.
Created attachment 123585 [details] [review] Bug 28390: Move timestamp into grouping row This patch moves the timestamp that was getting repeated for each transaction breakdown row into the group header row. Test plan 1/ Add a series of transactions to to a register (via Point of Sale or/and Borrower Accounts) 2/ View the transactions (and past transactions tables) on the Register details page 3/ Apply the patch and compare the display Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 21.11, thanks to everybody involved!