Bug 28548 - Clarify "frombranch" flag in overdue_notices.pl
Summary: Clarify "frombranch" flag in overdue_notices.pl
Status: RESOLVED DUPLICATE of bug 39887
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2021-06-10 15:04 UTC by Andrew Fuerste-Henry
Modified: 2026-02-25 19:57 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2021-06-10 15:04:20 UTC
The cronjob overdue_notices.pl includes this text in its options:
"   --frombranch                   Set the from address for the notice to one of 'item-homebranch' or 'item-issuebranch'."

While that text suggests that the --frombranch flag will only change which branch's address info is populated in overdue notices, this flag actually controls which branch's triggers will be used as well as which branch's notice content will be used.

We should change that text to: Set the branch to use when selecting triggers and populating addresses. Available options are 'item-homebranch' or 'item-issuebranch'.
Comment 1 Caroline Cyr La Rose 2026-02-25 16:33:26 UTC
Is this still valid? This is what I see in the script or when running with --help


       --frombranch                    Organize and send overdue notices by home library (item-homebranch) or checkout library (item-issuebranch) or patron home library (patron-homebranch).
                                       This option is only used, if the OverdueNoticeFrom system preference is set to 'command-line option'.
                                       Defaults to item-issuebranch.


and then lower down


    --frombranch
            Organize overdue notices either by checkout library
            (item-issuebranch) or item home library (item-homebranch) or
            patron home library (patron-homebranch). This option is only
            used if the OverdueNoticeFrom system preference is set to use
            'command-line option'. Defaults to checkout library
            (item-issuebranch).

            This setting affects which branch is considered the "source" of
            the notice, which in turn affects various aspects of the notice,
            including the content, branding, and from email address.


Maybe the help text was revised when the patron-homebranch option was added?
Comment 2 Caroline Cyr La Rose 2026-02-25 16:37:11 UTC
Ah no, it seems Martin reviewed the documentation in bug 39887. I think we can mark this one as resolved duplicate, what do you think Andrew?
Comment 3 Andrew Fuerste-Henry 2026-02-25 19:57:29 UTC
(In reply to Caroline Cyr La Rose from comment #2)
> Ah no, it seems Martin reviewed the documentation in bug 39887. I think we
> can mark this one as resolved duplicate, what do you think Andrew?

Doing so now. Thanks for catching it!

*** This bug has been marked as a duplicate of bug 39887 ***