Bug 28548 - Clarify "frombranch" flag in overdue_notices.pl
Summary: Clarify "frombranch" flag in overdue_notices.pl
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2021-06-10 15:04 UTC by Andrew Fuerste-Henry
Modified: 2022-02-19 22:36 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2021-06-10 15:04:20 UTC 
The cronjob overdue_notices.pl includes this text in its options:
"   --frombranch                   Set the from address for the notice to one of 'item-homebranch' or 'item-issuebranch'."

While that text suggests that the --frombranch flag will only change which branch's address info is populated in overdue notices, this flag actually controls which branch's triggers will be used as well as which branch's notice content will be used.

We should change that text to: Set the branch to use when selecting triggers and populating addresses. Available options are 'item-homebranch' or 'item-issuebranch'.